Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Remove explicit storage requirement from README.md #14511

Merged
merged 1 commit into from Oct 23, 2018

Conversation

Projects
None yet
8 participants
@merland
Copy link
Contributor

commented Oct 18, 2018

Similarly discussed and fixed in the following bitcoin.org issue: bitcoin-dot-org/bitcoin.org#2716

@fanquake fanquake added the Docs label Oct 18, 2018

@laanwj

This comment has been minimized.

Copy link
Member

commented Oct 18, 2018

didn't even know there was another reference to the size here; there's this one in the release process

* Update [`BLOCK_CHAIN_SIZE`](/src/qt/intro.cpp) to the current size plus some overhead

maybe better to remove this one completely

Show resolved Hide resolved doc/README.md Outdated
@laanwj

This comment has been minimized.

Copy link
Member

commented Oct 18, 2018

looks good to me now!

@jonasschnelli

This comment has been minimized.

Copy link
Member

commented Oct 18, 2018

ACK 3a4757c2bba8cd59c08dc8b717e527115018c600

@promag

This comment has been minimized.

Copy link
Member

commented Oct 18, 2018

ACK.

@donaloconnor

This comment has been minimized.

Copy link
Contributor

commented Oct 18, 2018

ACK

Show resolved Hide resolved doc/README.md Outdated

@fanquake fanquake changed the title Increase storage requirement from 100GB to 200GB doc: Remove explicit storage requirement from README.md Oct 19, 2018

@fanquake

This comment has been minimized.

Copy link
Member

commented Oct 19, 2018

ACK please squash your commits

@merland merland force-pushed the merland:patch-1 branch 2 times, most recently Oct 22, 2018

Removed explicit mention of storage requirement (squashed)
Similarly discussed and fixed in the following bitcoin.org issue: bitcoin-dot-org/bitcoin.org#2716

Removed mention of storage requirement

Agreeing with @laanwj that this mention of the storage requirement could be removed, I did so and changed the wording accordingly.
Would be nice to be able to add a link to a canonical source that is always updated, for those who want a number.

Update doc/README.md

Co-Authored-By: merland <martin@megabit.se>

Update README.md

added a missing 'a'

@merland merland force-pushed the merland:patch-1 branch to 5918204 Oct 22, 2018

@merland

This comment has been minimized.

Copy link
Contributor Author

commented Oct 22, 2018

Thanks for your comments. Squashed 4 commits.

@fanquake

This comment has been minimized.

Copy link
Member

commented Oct 22, 2018

utACK 5918204

@sipa

This comment has been minimized.

Copy link
Member

commented Oct 23, 2018

ACK

@sipa sipa merged commit 5918204 into bitcoin:master Oct 23, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

sipa added a commit that referenced this pull request Oct 23, 2018

Merge #14511: doc: Remove explicit storage requirement from README.md
5918204 Removed explicit mention of storage requirement (squashed) (Martin Erlandsson)

Pull request description:

  Similarly discussed and fixed in the following bitcoin.org issue: bitcoin-dot-org/bitcoin.org#2716

Tree-SHA512: 3d1e0b1e70c2e2a5003f437c7deba8bc72f487852948c298db154aaf29184fa407e122ab7fdff9bfb4e52cc6062bc2d2122bbbdf805283aed21aa685cf29681c

@merland merland deleted the merland:patch-1 branch Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.