Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: Always throw in getblockstats if -txindex is required #14518

Merged
merged 1 commit into from Oct 26, 2018

Conversation

Projects
None yet
6 participants
@promag
Copy link
Member

commented Oct 19, 2018

Previously blocks with only the coinbase transaction didn't cause
the RPC error even if the requested stats required -txindex and
it wasn't enabled.

Fixes #14499.

rpc: Always throw in getblockstats if -txindex is required
Previously blocks with only the coinbase transaction didn't cause
the RPC error even if the requested stats required -txindex and
it wasn't enabled.
@sipa

This comment has been minimized.

Copy link
Member

commented Oct 20, 2018

utACK 3be209d

1 similar comment
@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Oct 20, 2018

utACK 3be209d

@promag

This comment has been minimized.

Copy link
Member Author

commented Oct 24, 2018

@jtimon @gmaxwell care to review?

@conscott

This comment has been minimized.

Copy link
Contributor

commented Oct 25, 2018

Tested ACK 3be209d

I had also been confused by this behavior before, so this seems right.

@laanwj

This comment has been minimized.

Copy link
Member

commented Oct 26, 2018

utACK 3be209d

@laanwj laanwj added the Backport label Oct 26, 2018

@laanwj laanwj added this to the 0.17.1 milestone Oct 26, 2018

@laanwj laanwj merged commit 3be209d into bitcoin:master Oct 26, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Oct 26, 2018

Merge #14518: rpc: Always throw in getblockstats if -txindex is required
3be209d rpc: Always throw in getblockstats if -txindex is required (João Barbosa)

Pull request description:

  Previously blocks with only the coinbase transaction didn't cause
  the RPC error even if the requested stats required -txindex and
  it wasn't enabled.

  Fixes #14499.

Tree-SHA512: d3a6402889e3ce7199632e79eba66d7d471ff7de5c564d35312e2340cc6d84ef544a8172548fbc2eedf5e637b56dc57bbf7a9815ab798c7f226755f897fd8f3e

@promag promag deleted the promag:2018-10-getblockstats branch Oct 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.