Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: Always throw in getblockstats if -txindex is required #14518

Merged
merged 1 commit into from Oct 26, 2018

Conversation

@promag
Copy link
Member

@promag promag commented Oct 19, 2018

Previously blocks with only the coinbase transaction didn't cause
the RPC error even if the requested stats required -txindex and
it wasn't enabled.

Fixes #14499.

Previously blocks with only the coinbase transaction didn't cause
the RPC error even if the requested stats required -txindex and
it wasn't enabled.
@sipa
Copy link
Member

@sipa sipa commented Oct 20, 2018

utACK 3be209d

1 similar comment
@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Oct 20, 2018

utACK 3be209d

@promag
Copy link
Member Author

@promag promag commented Oct 24, 2018

@jtimon @gmaxwell care to review?

@conscott
Copy link
Contributor

@conscott conscott commented Oct 25, 2018

Tested ACK 3be209d

I had also been confused by this behavior before, so this seems right.

@laanwj
Copy link
Member

@laanwj laanwj commented Oct 26, 2018

utACK 3be209d

@laanwj laanwj added this to the 0.17.1 milestone Oct 26, 2018
@laanwj laanwj merged commit 3be209d into bitcoin:master Oct 26, 2018
2 checks passed
laanwj added a commit that referenced this issue Oct 26, 2018
3be209d rpc: Always throw in getblockstats if -txindex is required (João Barbosa)

Pull request description:

  Previously blocks with only the coinbase transaction didn't cause
  the RPC error even if the requested stats required -txindex and
  it wasn't enabled.

  Fixes #14499.

Tree-SHA512: d3a6402889e3ce7199632e79eba66d7d471ff7de5c564d35312e2340cc6d84ef544a8172548fbc2eedf5e637b56dc57bbf7a9815ab798c7f226755f897fd8f3e
@promag promag deleted the 2018-10-getblockstats branch Oct 26, 2018
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue May 29, 2020
…quired

Summary:
3be209d103297aaf2fe4711e237a65046488ea19 rpc: Always throw in getblockstats if -txindex is required (João Barbosa)

Pull request description:

  Previously blocks with only the coinbase transaction didn't cause
  the RPC error even if the requested stats required -txindex and
  it wasn't enabled.

  Fixes #14499.

---

bitcoin/bitcoin@3be209d

Backport of Core [[bitcoin/bitcoin#14518 | PR14518]]

Test Plan:
  ninja check-all

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6287
Munkybooty added a commit to Munkybooty/dash that referenced this issue Jul 21, 2021
…s required

3be209d rpc: Always throw in getblockstats if -txindex is required (João Barbosa)

Pull request description:

  Previously blocks with only the coinbase transaction didn't cause
  the RPC error even if the requested stats required -txindex and
  it wasn't enabled.

  Fixes bitcoin#14499.

Tree-SHA512: d3a6402889e3ce7199632e79eba66d7d471ff7de5c564d35312e2340cc6d84ef544a8172548fbc2eedf5e637b56dc57bbf7a9815ab798c7f226755f897fd8f3e
Munkybooty added a commit to Munkybooty/dash that referenced this issue Jul 21, 2021
…s required

3be209d rpc: Always throw in getblockstats if -txindex is required (João Barbosa)

Pull request description:

  Previously blocks with only the coinbase transaction didn't cause
  the RPC error even if the requested stats required -txindex and
  it wasn't enabled.

  Fixes bitcoin#14499.

Tree-SHA512: d3a6402889e3ce7199632e79eba66d7d471ff7de5c564d35312e2340cc6d84ef544a8172548fbc2eedf5e637b56dc57bbf7a9815ab798c7f226755f897fd8f3e
Munkybooty added a commit to Munkybooty/dash that referenced this issue Jul 22, 2021
…s required

3be209d rpc: Always throw in getblockstats if -txindex is required (João Barbosa)

Pull request description:

  Previously blocks with only the coinbase transaction didn't cause
  the RPC error even if the requested stats required -txindex and
  it wasn't enabled.

  Fixes bitcoin#14499.

Tree-SHA512: d3a6402889e3ce7199632e79eba66d7d471ff7de5c564d35312e2340cc6d84ef544a8172548fbc2eedf5e637b56dc57bbf7a9815ab798c7f226755f897fd8f3e
Munkybooty added a commit to Munkybooty/dash that referenced this issue Jul 22, 2021
…s required

3be209d rpc: Always throw in getblockstats if -txindex is required (João Barbosa)

Pull request description:

  Previously blocks with only the coinbase transaction didn't cause
  the RPC error even if the requested stats required -txindex and
  it wasn't enabled.

  Fixes bitcoin#14499.

Tree-SHA512: d3a6402889e3ce7199632e79eba66d7d471ff7de5c564d35312e2340cc6d84ef544a8172548fbc2eedf5e637b56dc57bbf7a9815ab798c7f226755f897fd8f3e
Munkybooty added a commit to Munkybooty/dash that referenced this issue Jul 23, 2021
…s required

3be209d rpc: Always throw in getblockstats if -txindex is required (João Barbosa)

Pull request description:

  Previously blocks with only the coinbase transaction didn't cause
  the RPC error even if the requested stats required -txindex and
  it wasn't enabled.

  Fixes bitcoin#14499.

Tree-SHA512: d3a6402889e3ce7199632e79eba66d7d471ff7de5c564d35312e2340cc6d84ef544a8172548fbc2eedf5e637b56dc57bbf7a9815ab798c7f226755f897fd8f3e
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
6 participants