Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Document lint tests #14526

Merged
merged 1 commit into from Oct 21, 2018
Merged

Conversation

@fanquake
Copy link
Member

@fanquake fanquake commented Oct 20, 2018

Replaces #13708.
Fixed the macOS nit, and added codespell as a requirement.


#### Dependencies

The lint tests require codespell and flake8. To install: `pip3 install codespell flake8`.
Copy link
Member

@promag promag Oct 20, 2018

Just noting that I think it should not specify versions, this way new lint errors can be detected and the source fixed accordingly.

@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Oct 20, 2018

Nice!

ACK 8640631

@MarcoFalke MarcoFalke merged commit 8640631 into bitcoin:master Oct 21, 2018
2 checks passed
MarcoFalke added a commit that referenced this issue Oct 21, 2018
8640631 docs: Document lint tests (Mason Simon)

Pull request description:

  Replaces #13708.
  Fixed the macOS nit, and added `codespell` as a requirement.

Tree-SHA512: efdef8238f9d4433cc6403f58075b906d39d6a2114821cb113a16f2fc45d0c10c603588272865edd40a0498d9685ff8ac25d2491d9fcf0f1f328b6d65751ac2c
@fanquake fanquake deleted the revive-document-lint-tests branch Nov 21, 2018
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jul 17, 2021
8640631 docs: Document lint tests (Mason Simon)

Pull request description:

  Replaces bitcoin#13708.
  Fixed the macOS nit, and added `codespell` as a requirement.

Tree-SHA512: efdef8238f9d4433cc6403f58075b906d39d6a2114821cb113a16f2fc45d0c10c603588272865edd40a0498d9685ff8ac25d2491d9fcf0f1f328b6d65751ac2c
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants