Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa: Revert "Make qt wallet test compatible with qt4" #14527

Merged
merged 1 commit into from Oct 20, 2018

Conversation

Projects
None yet
6 participants
@MarcoFalke
Copy link
Member

commented Oct 20, 2018

This removes the file added in #10098

@MarcoFalke MarcoFalke changed the title Revert "Make qt wallet test compatible with qt4" qa: Revert "Make qt wallet test compatible with qt4" Oct 20, 2018

@MarcoFalke MarcoFalke force-pushed the MarcoFalke:Mf1810-qtRemoveQT4file branch to fadffae Oct 20, 2018

@fanquake

This comment has been minimized.

Copy link
Member

commented Oct 20, 2018

Concept ACK

Needs to be rebased for #14011.

@promag

This comment has been minimized.

Copy link
Member

commented Oct 20, 2018

utACK fadffae.

@promag

This comment has been minimized.

Copy link
Member

commented Oct 20, 2018

Is Qt 5.4 the minimum supported version?

@hebasto

This comment has been minimized.

Copy link
Member

commented Oct 20, 2018

utACK fadffae

@MarcoFalke

This comment has been minimized.

Copy link
Member Author

commented Oct 20, 2018

@promag Looks like it right now. See #13478 (comment)

@ken2812221

This comment has been minimized.

Copy link
Member

commented Oct 20, 2018

utACK fadffae

@laanwj

This comment has been minimized.

Copy link
Member

commented Oct 20, 2018

utACK fadffae
good catch—somehow expected we'd have removed the qt4 workarounds by now, but this one was hiding

@laanwj laanwj merged commit fadffae into bitcoin:master Oct 20, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Oct 20, 2018

Merge #14527: qa: Revert "Make qt wallet test compatible with qt4"
fadffae Revert "Make qt wallet test compatible with qt4" (MarcoFalke)

Pull request description:

  This removes the file added in #10098

Tree-SHA512: 4aa887ec02aec943f3d74f469c935acf57e43ddbea6f979bb37d3a14670571fa2276cf578e8978de92b5854d8b462f24e5e0addfb27b92fbedf90726eb5d985e

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1810-qtRemoveQT4file branch Oct 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.