Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa: Revert "Make qt wallet test compatible with qt4" #14527

Merged
merged 1 commit into from Oct 20, 2018

Conversation

@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Oct 20, 2018

This removes the file added in #10098

@MarcoFalke MarcoFalke changed the title Revert "Make qt wallet test compatible with qt4" qa: Revert "Make qt wallet test compatible with qt4" Oct 20, 2018
@MarcoFalke MarcoFalke force-pushed the Mf1810-qtRemoveQT4file branch from fa6b97b to fadffae Oct 20, 2018
@fanquake
Copy link
Member

@fanquake fanquake commented Oct 20, 2018

Concept ACK

Needs to be rebased for #14011.

@promag
Copy link
Member

@promag promag commented Oct 20, 2018

utACK fadffae.

@promag
Copy link
Member

@promag promag commented Oct 20, 2018

Is Qt 5.4 the minimum supported version?

@hebasto
Copy link
Member

@hebasto hebasto commented Oct 20, 2018

utACK fadffae

@MarcoFalke
Copy link
Member Author

@MarcoFalke MarcoFalke commented Oct 20, 2018

@promag Looks like it right now. See #13478 (comment)

@ken2812221
Copy link
Contributor

@ken2812221 ken2812221 commented Oct 20, 2018

utACK fadffae

@laanwj
Copy link
Member

@laanwj laanwj commented Oct 20, 2018

utACK fadffae
good catch—somehow expected we'd have removed the qt4 workarounds by now, but this one was hiding

@laanwj laanwj merged commit fadffae into bitcoin:master Oct 20, 2018
2 checks passed
laanwj added a commit that referenced this issue Oct 20, 2018
fadffae Revert "Make qt wallet test compatible with qt4" (MarcoFalke)

Pull request description:

  This removes the file added in #10098

Tree-SHA512: 4aa887ec02aec943f3d74f469c935acf57e43ddbea6f979bb37d3a14670571fa2276cf578e8978de92b5854d8b462f24e5e0addfb27b92fbedf90726eb5d985e
@MarcoFalke MarcoFalke deleted the Mf1810-qtRemoveQT4file branch Oct 20, 2018
ogabrielides added a commit to ogabrielides/dash that referenced this issue Oct 26, 2021
…qt4"

fadffae Revert "Make qt wallet test compatible with qt4" (MarcoFalke)

Pull request description:

  This removes the file added in bitcoin#10098

Tree-SHA512: 4aa887ec02aec943f3d74f469c935acf57e43ddbea6f979bb37d3a14670571fa2276cf578e8978de92b5854d8b462f24e5e0addfb27b92fbedf90726eb5d985e
PastaPastaPasta pushed a commit to dashpay/dash that referenced this issue Oct 26, 2021
…qt4" (#4547)

fadffae Revert "Make qt wallet test compatible with qt4" (MarcoFalke)

Pull request description:

  This removes the file added in bitcoin#10098

Tree-SHA512: 4aa887ec02aec943f3d74f469c935acf57e43ddbea6f979bb37d3a14670571fa2276cf578e8978de92b5854d8b462f24e5e0addfb27b92fbedf90726eb5d985e

Co-authored-by: Wladimir J. van der Laan <laanwj@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants