Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] minor p2p_sendheaders fix of height in coinbase #14543

Merged
merged 1 commit into from Feb 12, 2019

Conversation

Projects
None yet
5 participants
@instagibbs
Copy link
Member

commented Oct 22, 2018

# Now announce a header that forks the last two blocks

Doesn't effect any behavior since BIP34 isn't active in regtest for many blocks.

@fanquake fanquake added the Tests label Oct 22, 2018

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Nov 2, 2018

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

@laanwj

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

utACK 1cdb9bb

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Feb 12, 2019

Merge bitcoin#14543: [QA] minor p2p_sendheaders fix of height in coin…
…base

1cdb9bb minor p2p_sendheaders fix of height in coinbase (Gregory Sanders)

Pull request description:

  > \# Now announce a header that forks the last two blocks

  Doesn't effect any behavior since BIP34 isn't active in regtest for many blocks.

Tree-SHA512: 3f214b956a94250bb640f63b6ff707930e1d4cb8df1bbf0fef4012d89a94bafbde0d7b42bbe7113ec33810169281c22c6e389445921d99decb74aa56e87a0f27

@MarcoFalke MarcoFalke merged commit 1cdb9bb into bitcoin:master Feb 12, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.