Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Fix Qt link order for Windows build #14568

Merged
merged 1 commit into from Oct 26, 2018

Conversation

Projects
None yet
7 participants
@ken2812221
Copy link
Member

commented Oct 25, 2018

@laanwj

This comment has been minimized.

Copy link
Member

commented Oct 25, 2018

great!

can you please explain how swapping these around fixes the build? something with qt depending on libssl?

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Oct 25, 2018

Concept ACK. Also interesting that travis didn't fail on this. travis apparently doesn't build the gui.

@ryanofsky
Copy link
Contributor

left a comment

utACK fbaccbf. Seems clearly correct, SSL_LIBS should be listed after the libraries that depend on it.

@ken2812221

This comment has been minimized.

Copy link
Member Author

commented Oct 26, 2018

can you please explain how swapping these around fixes the build? something with qt depending on libssl?

libssl should be listed after libQt5Network because the later one depends on the former one.

@jameshilliard

This comment has been minimized.

Copy link
Contributor

commented Oct 26, 2018

Any idea why the link order here only seems to cause issues on windows builds and not linux/osx?

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Oct 26, 2018

Gitian builds for commit 754a00d (master):

Gitian builds for commit 3dbc5bc94e8ebfdcfac57f76b987eb17a7a92aa5 (master and this pull):

@MarcoFalke MarcoFalke merged commit fbaccbf into bitcoin:master Oct 26, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

MarcoFalke added a commit that referenced this pull request Oct 26, 2018

Merge #14568: build: Fix Qt link order for Windows build
fbaccbf build: Fix Qt link order for Windows build (Chun Kuan Lee)

Pull request description:

  See #14451 (comment)

Tree-SHA512: 819e68dc750297a74d04aa1ad3dae64072b66df718d36b950bd9430c9fca1771c611af934df23954f81b83bd89f96ea76c20cbf17db1364b988a6c34c43fb631

@ken2812221 ken2812221 deleted the ken2812221:win-qt-fix branch Nov 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.