Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Fix Qt link order for Windows build #14568

Merged
merged 1 commit into from Oct 26, 2018
Merged

Conversation

@ken2812221
Copy link
Contributor

@ken2812221 ken2812221 commented Oct 25, 2018

See #14451 (comment)

@laanwj
Copy link
Member

@laanwj laanwj commented Oct 25, 2018

great!

can you please explain how swapping these around fixes the build? something with qt depending on libssl?

@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Oct 25, 2018

Concept ACK. Also interesting that travis didn't fail on this. travis apparently doesn't build the gui.

Copy link
Contributor

@ryanofsky ryanofsky left a comment

utACK fbaccbf. Seems clearly correct, SSL_LIBS should be listed after the libraries that depend on it.

@ken2812221
Copy link
Contributor Author

@ken2812221 ken2812221 commented Oct 26, 2018

can you please explain how swapping these around fixes the build? something with qt depending on libssl?

libssl should be listed after libQt5Network because the later one depends on the former one.

@jameshilliard
Copy link
Contributor

@jameshilliard jameshilliard commented Oct 26, 2018

Any idea why the link order here only seems to cause issues on windows builds and not linux/osx?

@DrahtBot
Copy link
Contributor

@DrahtBot DrahtBot commented Oct 26, 2018

Gitian builds for commit 754a00d (master):

Gitian builds for commit 3dbc5bc94e8ebfdcfac57f76b987eb17a7a92aa5 (master and this pull):

@MarcoFalke MarcoFalke merged commit fbaccbf into bitcoin:master Oct 26, 2018
2 checks passed
MarcoFalke added a commit that referenced this issue Oct 26, 2018
fbaccbf build: Fix Qt link order for Windows build (Chun Kuan Lee)

Pull request description:

  See #14451 (comment)

Tree-SHA512: 819e68dc750297a74d04aa1ad3dae64072b66df718d36b950bd9430c9fca1771c611af934df23954f81b83bd89f96ea76c20cbf17db1364b988a6c34c43fb631
@ken2812221 ken2812221 deleted the win-qt-fix branch Nov 3, 2018
dzutte-cpp added a commit to dzutte-cpp/dash that referenced this issue Aug 19, 2021
fbaccbf build: Fix Qt link order for Windows build (Chun Kuan Lee)

Pull request description:

  See bitcoin#14451 (comment)

Tree-SHA512: 819e68dc750297a74d04aa1ad3dae64072b66df718d36b950bd9430c9fca1771c611af934df23954f81b83bd89f96ea76c20cbf17db1364b988a6c34c43fb631
dzutte-cpp added a commit to dzutte-cpp/dash that referenced this issue Aug 19, 2021
fbaccbf build: Fix Qt link order for Windows build (Chun Kuan Lee)

Pull request description:

  See bitcoin#14451 (comment)

Tree-SHA512: 819e68dc750297a74d04aa1ad3dae64072b66df718d36b950bd9430c9fca1771c611af934df23954f81b83bd89f96ea76c20cbf17db1364b988a6c34c43fb631
dzutte-cpp added a commit to dzutte-cpp/dash that referenced this issue Aug 19, 2021
fbaccbf build: Fix Qt link order for Windows build (Chun Kuan Lee)

Pull request description:

  See bitcoin#14451 (comment)

Tree-SHA512: 819e68dc750297a74d04aa1ad3dae64072b66df718d36b950bd9430c9fca1771c611af934df23954f81b83bd89f96ea76c20cbf17db1364b988a6c34c43fb631
dzutte-cpp added a commit to dzutte-cpp/dash that referenced this issue Aug 23, 2021
fbaccbf build: Fix Qt link order for Windows build (Chun Kuan Lee)

Pull request description:

  See bitcoin#14451 (comment)

Tree-SHA512: 819e68dc750297a74d04aa1ad3dae64072b66df718d36b950bd9430c9fca1771c611af934df23954f81b83bd89f96ea76c20cbf17db1364b988a6c34c43fb631
dzutte-cpp added a commit to dzutte-cpp/dash that referenced this issue Aug 26, 2021
fbaccbf build: Fix Qt link order for Windows build (Chun Kuan Lee)

Pull request description:

  See bitcoin#14451 (comment)

Tree-SHA512: 819e68dc750297a74d04aa1ad3dae64072b66df718d36b950bd9430c9fca1771c611af934df23954f81b83bd89f96ea76c20cbf17db1364b988a6c34c43fb631
dzutte-cpp added a commit to dzutte-cpp/dash that referenced this issue Aug 26, 2021
fbaccbf build: Fix Qt link order for Windows build (Chun Kuan Lee)

Pull request description:

  See bitcoin#14451 (comment)

Tree-SHA512: 819e68dc750297a74d04aa1ad3dae64072b66df718d36b950bd9430c9fca1771c611af934df23954f81b83bd89f96ea76c20cbf17db1364b988a6c34c43fb631
dzutte-cpp added a commit to dzutte-cpp/dash that referenced this issue Aug 27, 2021
fbaccbf build: Fix Qt link order for Windows build (Chun Kuan Lee)

Pull request description:

  See bitcoin#14451 (comment)

Tree-SHA512: 819e68dc750297a74d04aa1ad3dae64072b66df718d36b950bd9430c9fca1771c611af934df23954f81b83bd89f96ea76c20cbf17db1364b988a6c34c43fb631
PastaPastaPasta added a commit to dashpay/dash that referenced this issue Aug 29, 2021
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants