Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt: Remove the "Pay only required fee..." checkbox #14608

Merged

Conversation

Projects
None yet
6 participants
@hebasto
Copy link
Member

commented Oct 30, 2018

Ref #13280
This PR removes the "Pay only the required fee..." checkbox from the custom transaction fee section in the "Send" tab. Instead, a minimum value will be enforced on the custom fee input box.

All comments from #13280 are addressed.

Before:
screenshot from 2018-10-30 16-42-18

After:
screenshot from 2018-10-30 16-40-37

cc: @promag @MarcoFalke @Sjors

hebasto added some commits Oct 30, 2018

qt: Improve BitcoinAmountField class
This adds functions for specifing a min/max value for a
BitcoinAmountField. These options only affect user input, so it's still
possible to use setValue to set values outside of the min/max range. The
existing value will not be changed when calling these functions even if
it's out of range. The min/max range will be reinforced when the field
loses focus.
This also adds `SetAllowEmpty` function which specifies if the field is
allowed to be left empty by the user. If set to false the field will be
set to the minimum allowed value if it's empty when focus is lost.
qt: Remove "Pay only required fee" checkbox
The custom fee input box now has a minimum value equal to the minimum
required fee. Before a value below the minimum fee could be entered
which was confusing since the minimum fee would still be paid even
though a lower amount was entered.

@fanquake fanquake added the GUI label Oct 30, 2018

@fanquake fanquake requested a review from jonasschnelli Nov 2, 2018

@Sjors

This comment has been minimized.

Copy link
Member

commented Nov 2, 2018

tACK a16f44c on macOS 10.14.1

It doesn't make sense to cap the max fee rate at 21 000 000 BTC per kilobyte, but there's no harm either.

@jonasschnelli

This comment has been minimized.

Copy link
Member

commented Nov 4, 2018

Concept ACK

@bitcoin bitcoin deleted a comment from ismail120572 Nov 4, 2018

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Nov 6, 2018

utACK a16f44c

@jonasschnelli
Copy link
Member

left a comment

utACK a16f44c

@laanwj

This comment has been minimized.

Copy link
Member

commented Nov 10, 2018

Concept ACK

@jonasschnelli

This comment has been minimized.

Copy link
Member

commented Nov 13, 2018

Tested ACK a16f44c

@jonasschnelli jonasschnelli merged commit a16f44c into bitcoin:master Nov 13, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jonasschnelli added a commit that referenced this pull request Nov 13, 2018

Merge #14608: qt: Remove the "Pay only required fee..." checkbox
a16f44c qt: Remove "Pay only required fee" checkbox (Hennadii Stepanov)
8711cc0 qt: Improve BitcoinAmountField class (Hennadii Stepanov)

Pull request description:

  Ref #13280
  This PR removes the "Pay only the required fee..." checkbox from the custom transaction fee section in the "Send" tab. Instead, a minimum value will be enforced on the custom fee input box.

  All comments from #13280 are addressed.

  Before:
  ![screenshot from 2018-10-30 16-42-18](https://user-images.githubusercontent.com/32963518/47726622-866d8e80-dc63-11e8-8670-3f97ff0fa5da.png)

  After:
  ![screenshot from 2018-10-30 16-40-37](https://user-images.githubusercontent.com/32963518/47726633-8f5e6000-dc63-11e8-82cf-5b9ff4aae91d.png)

  cc: @promag @MarcoFalke @Sjors

Tree-SHA512: 073577d38d8353b10e8f36fb52e3c6e81dd45d25d84df9b9e4f78f452ff0bdbff3e225bdd6122b5a03839ffdcc2a2a08175f81c2541cf2d12918536abbfa3fd1

@hebasto hebasto deleted the hebasto:20181030-remove-payonlyrequiredfee branch Nov 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.