Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeBSD: Document Python 3 requirement for 'gmake check' #14617

Merged
merged 1 commit into from Nov 1, 2018

Conversation

@murrayn
Copy link
Contributor

@murrayn murrayn commented Oct 31, 2018

doc/build-freebsd.md doesn't mention that Python 3 is required to run the test suite. Currently, gmake check fails without it.

@fanquake fanquake added the Docs label Oct 31, 2018
@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Oct 31, 2018

Concept ACK

@bitcoin bitcoin deleted a comment from ismail120572 Oct 31, 2018
@laanwj
Copy link
Member

@laanwj laanwj commented Oct 31, 2018

Makes sense.
For the sake of documentation simplicity I would be ok with mentioning python3 as simply one of the dependencies and not just for the tests. I think we do that for other platforms.

@murrayn
Copy link
Contributor Author

@murrayn murrayn commented Nov 1, 2018

@laanwj thanks for your input. I fully agree with you in general. For FreeBSD in particular, I think a sysadmin can decide whether installing Python 3 is worthwhile, rather than just adding another dependency. That was my thought process.

@laanwj
Copy link
Member

@laanwj laanwj commented Nov 1, 2018

utACK 0a04667

@laanwj laanwj merged commit 0a04667 into bitcoin:master Nov 1, 2018
1 check passed
laanwj added a commit that referenced this issue Nov 1, 2018
0a04667 FreeBSD: Document Python 3 requirement for 'gmake check' (Murray Nesbitt)

Pull request description:

  `doc/build-freebsd.md` doesn't mention that Python 3 is required to run the test suite. Currently, `gmake check` fails without it.

Tree-SHA512: 19117671bf528d335146d821e5cd4108f2f6ae014fb9a6d0030a322b23d1bc5f677e46896b575a7ca78b137315b60e63ad8b03ad695fe0aae3e9f50b060a3561
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants