Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
test_runner: Remove travis specific code #14630
referenced this pull request
Nov 1, 2018
Passing the value through touches a lot of function signatures and I run a python formatter on all changes I make before submitting a pull request. In the hope that no one can complain about my code style...
A lot of it seems like your personal preference for style, and it inflates the diff substantially. For example, I don't think there's project guidelines about whether continuation lines of long function calls should be aligned to the opening parens or to some other indentation (both are fine under PEP8 https://www.python.org/dev/peps/pep-0008/#indentation).
This seems like a +-5 line diff without the style changes. At the least, can you split the style changes into a separate commit so it's obvious what reviewers are supposed to be paying attention to?