Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_runner: Remove travis specific code #14630

Merged
merged 1 commit into from Nov 2, 2018

Conversation

@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Nov 1, 2018

The tests are no longer run on travis, but in a docker, developer machines or a windows vm.

The code was essentially dead for months now. Fix that by explicitly passing in --ci to the test runner on our docker and appveyor windows vm.

@laanwj laanwj added the Tests label Nov 1, 2018
@laanwj
Copy link
Member

@laanwj laanwj commented Nov 1, 2018

makes sense — concept ACK

@MarcoFalke MarcoFalke force-pushed the Mf1811-testNoTravis branch from fa04a3a to fadf976 Nov 1, 2018
@DrahtBot
Copy link
Contributor

@DrahtBot DrahtBot commented Nov 1, 2018

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

@jnewbery
Copy link
Member

@jnewbery jnewbery commented Nov 1, 2018

Concept ACK.

Why so many style-only changes in the same commit?

@MarcoFalke
Copy link
Member Author

@MarcoFalke MarcoFalke commented Nov 1, 2018

Passing the value through touches a lot of function signatures and I run a python formatter on all changes I make before submitting a pull request. In the hope that no one can complain about my code style...

$ which yfd
alias yfd='PATH=/home/marco/workspace/yapf-diff/virt_env_3_yapf/bin python3 /home/marco/workspace/yapf-diff/yapf-diff.py -p1 -i'

https://github.com/MarcoFalke/yapf-diff

@jnewbery
Copy link
Member

@jnewbery jnewbery commented Nov 1, 2018

A lot of it seems like your personal preference for style, and it inflates the diff substantially. For example, I don't think there's project guidelines about whether continuation lines of long function calls should be aligned to the opening parens or to some other indentation (both are fine under PEP8 https://www.python.org/dev/peps/pep-0008/#indentation).

This seems like a +-5 line diff without the style changes. At the least, can you split the style changes into a separate commit so it's obvious what reviewers are supposed to be paying attention to?

@MarcoFalke MarcoFalke force-pushed the Mf1811-testNoTravis branch from faf7770 to fa43626 Nov 1, 2018
@MarcoFalke
Copy link
Member Author

@MarcoFalke MarcoFalke commented Nov 1, 2018

Removed the style change that affected lines that were in proximity to actually changed lines.

Copy link
Contributor

@ken2812221 ken2812221 left a comment

utACK fa43626

@jnewbery
Copy link
Member

@jnewbery jnewbery commented Nov 2, 2018

utACK fa43626

MarcoFalke added a commit to MarcoFalke/bitcoin-core that referenced this issue Nov 2, 2018
fa43626 test_runner: Remove travis specific code (MarcoFalke)

Pull request description:

  The tests are no longer run on travis, but in a docker, developer machines or a windows vm.

  The code was essentially dead for months now. Fix that by explicitly passing in `--ci` to the test runner on our docker and appveyor windows vm.

Tree-SHA512: 5d48693c03e8eb27536658ccf9ba738fe93a72abd4b72c80caac084b5b2cdffa77a1031a671eeefe70b71d63500f55917803d4be54d01849722afdccb700a9e6
@MarcoFalke MarcoFalke merged commit fa43626 into bitcoin:master Nov 2, 2018
2 checks passed
@MarcoFalke MarcoFalke deleted the Mf1811-testNoTravis branch Nov 2, 2018
codablock added a commit to codablock/dash that referenced this issue Jan 7, 2020
fa43626 test_runner: Remove travis specific code (MarcoFalke)

Pull request description:

  The tests are no longer run on travis, but in a docker, developer machines or a windows vm.

  The code was essentially dead for months now. Fix that by explicitly passing in `--ci` to the test runner on our docker and appveyor windows vm.

Tree-SHA512: 5d48693c03e8eb27536658ccf9ba738fe93a72abd4b72c80caac084b5b2cdffa77a1031a671eeefe70b71d63500f55917803d4be54d01849722afdccb700a9e6
codablock added a commit to codablock/dash that referenced this issue Jan 7, 2020
commit 1e59b6a
Author: MarcoFalke <falke.marco@gmail.com>
Date:   Fri Nov 2 15:04:55 2018 -0400

    Merge bitcoin#14630: test_runner: Remove travis specific code

    fa43626 test_runner: Remove travis specific code (MarcoFalke)

    Pull request description:

      The tests are no longer run on travis, but in a docker, developer machines or a windows vm.

      The code was essentially dead for months now. Fix that by explicitly passing in `--ci` to the test runner on our docker and appveyor windows vm.

    Tree-SHA512: 5d48693c03e8eb27536658ccf9ba738fe93a72abd4b72c80caac084b5b2cdffa77a1031a671eeefe70b71d63500f55917803d4be54d01849722afdccb700a9e6

commit 4db0c1b
Author: Wladimir J. van der Laan <laanwj@gmail.com>
Date:   Mon Apr 30 15:19:26 2018 +0200

    Merge bitcoin#13105: [qa] Add --failfast option to functional test runner

    58f9a0a Use --failfast when running functional tests on Travis (James O'Beirne)
    bf720c1 Add --failfast option to functional test runner (James O'Beirne)

    Pull request description:

      Add the option (`--failfast`) to stop the functional test runner's execution when it encounters the first failure.

      Also cleans up run_test's arguments list ([no more mutable default for `args`](http://docs.python-guide.org/en/latest/writing/gotchas/#mutable-default-arguments)) and call site.

    Tree-SHA512: e854b1b1634bf613ae8ae88e715df1460982fa68db9d785aafeb5eccf5bf324c7f20dded2ca6840ebf18a28347ecac2138d6c7592507b34939b02609ef55e1b3
codablock added a commit to codablock/dash that referenced this issue Jan 7, 2020
commit 1e59b6a
Author: MarcoFalke <falke.marco@gmail.com>
Date:   Fri Nov 2 15:04:55 2018 -0400

    Merge bitcoin#14630: test_runner: Remove travis specific code

    fa43626 test_runner: Remove travis specific code (MarcoFalke)

    Pull request description:

      The tests are no longer run on travis, but in a docker, developer machines or a windows vm.

      The code was essentially dead for months now. Fix that by explicitly passing in `--ci` to the test runner on our docker and appveyor windows vm.

    Tree-SHA512: 5d48693c03e8eb27536658ccf9ba738fe93a72abd4b72c80caac084b5b2cdffa77a1031a671eeefe70b71d63500f55917803d4be54d01849722afdccb700a9e6

commit 4db0c1b
Author: Wladimir J. van der Laan <laanwj@gmail.com>
Date:   Mon Apr 30 15:19:26 2018 +0200

    Merge bitcoin#13105: [qa] Add --failfast option to functional test runner

    58f9a0a Use --failfast when running functional tests on Travis (James O'Beirne)
    bf720c1 Add --failfast option to functional test runner (James O'Beirne)

    Pull request description:

      Add the option (`--failfast`) to stop the functional test runner's execution when it encounters the first failure.

      Also cleans up run_test's arguments list ([no more mutable default for `args`](http://docs.python-guide.org/en/latest/writing/gotchas/#mutable-default-arguments)) and call site.

    Tree-SHA512: e854b1b1634bf613ae8ae88e715df1460982fa68db9d785aafeb5eccf5bf324c7f20dded2ca6840ebf18a28347ecac2138d6c7592507b34939b02609ef55e1b3
codablock added a commit to codablock/dash that referenced this issue Jan 7, 2020
fa43626 test_runner: Remove travis specific code (MarcoFalke)

Pull request description:

  The tests are no longer run on travis, but in a docker, developer machines or a windows vm.

  The code was essentially dead for months now. Fix that by explicitly passing in `--ci` to the test runner on our docker and appveyor windows vm.

Tree-SHA512: 5d48693c03e8eb27536658ccf9ba738fe93a72abd4b72c80caac084b5b2cdffa77a1031a671eeefe70b71d63500f55917803d4be54d01849722afdccb700a9e6
ckti added a commit to ckti-ioncore-current/ion that referenced this issue Mar 28, 2021
fa43626 test_runner: Remove travis specific code (MarcoFalke)

Pull request description:

  The tests are no longer run on travis, but in a docker, developer machines or a windows vm.

  The code was essentially dead for months now. Fix that by explicitly passing in `--ci` to the test runner on our docker and appveyor windows vm.

Tree-SHA512: 5d48693c03e8eb27536658ccf9ba738fe93a72abd4b72c80caac084b5b2cdffa77a1031a671eeefe70b71d63500f55917803d4be54d01849722afdccb700a9e6
gades added a commit to cosanta/cosanta-core that referenced this issue Jun 30, 2021
fa43626 test_runner: Remove travis specific code (MarcoFalke)

Pull request description:

  The tests are no longer run on travis, but in a docker, developer machines or a windows vm.

  The code was essentially dead for months now. Fix that by explicitly passing in `--ci` to the test runner on our docker and appveyor windows vm.

Tree-SHA512: 5d48693c03e8eb27536658ccf9ba738fe93a72abd4b72c80caac084b5b2cdffa77a1031a671eeefe70b71d63500f55917803d4be54d01849722afdccb700a9e6
Munkybooty added a commit to Munkybooty/dash that referenced this issue Jul 22, 2021
fa43626 test_runner: Remove travis specific code (MarcoFalke)

Pull request description:

  The tests are no longer run on travis, but in a docker, developer machines or a windows vm.

  The code was essentially dead for months now. Fix that by explicitly passing in `--ci` to the test runner on our docker and appveyor windows vm.

Tree-SHA512: 5d48693c03e8eb27536658ccf9ba738fe93a72abd4b72c80caac084b5b2cdffa77a1031a671eeefe70b71d63500f55917803d4be54d01849722afdccb700a9e6
Munkybooty added a commit to Munkybooty/dash that referenced this issue Jul 22, 2021
fa43626 test_runner: Remove travis specific code (MarcoFalke)

Pull request description:

  The tests are no longer run on travis, but in a docker, developer machines or a windows vm.

  The code was essentially dead for months now. Fix that by explicitly passing in `--ci` to the test runner on our docker and appveyor windows vm.

Tree-SHA512: 5d48693c03e8eb27536658ccf9ba738fe93a72abd4b72c80caac084b5b2cdffa77a1031a671eeefe70b71d63500f55917803d4be54d01849722afdccb700a9e6
Munkybooty added a commit to Munkybooty/dash that referenced this issue Jul 22, 2021
fa43626 test_runner: Remove travis specific code (MarcoFalke)

Pull request description:

  The tests are no longer run on travis, but in a docker, developer machines or a windows vm.

  The code was essentially dead for months now. Fix that by explicitly passing in `--ci` to the test runner on our docker and appveyor windows vm.

Tree-SHA512: 5d48693c03e8eb27536658ccf9ba738fe93a72abd4b72c80caac084b5b2cdffa77a1031a671eeefe70b71d63500f55917803d4be54d01849722afdccb700a9e6
Munkybooty added a commit to Munkybooty/dash that referenced this issue Jul 23, 2021
fa43626 test_runner: Remove travis specific code (MarcoFalke)

Pull request description:

  The tests are no longer run on travis, but in a docker, developer machines or a windows vm.

  The code was essentially dead for months now. Fix that by explicitly passing in `--ci` to the test runner on our docker and appveyor windows vm.

Tree-SHA512: 5d48693c03e8eb27536658ccf9ba738fe93a72abd4b72c80caac084b5b2cdffa77a1031a671eeefe70b71d63500f55917803d4be54d01849722afdccb700a9e6
Munkybooty added a commit to Munkybooty/dash that referenced this issue Jul 23, 2021
fa43626 test_runner: Remove travis specific code (MarcoFalke)

Pull request description:

  The tests are no longer run on travis, but in a docker, developer machines or a windows vm.

  The code was essentially dead for months now. Fix that by explicitly passing in `--ci` to the test runner on our docker and appveyor windows vm.

Tree-SHA512: 5d48693c03e8eb27536658ccf9ba738fe93a72abd4b72c80caac084b5b2cdffa77a1031a671eeefe70b71d63500f55917803d4be54d01849722afdccb700a9e6
Munkybooty added a commit to Munkybooty/dash that referenced this issue Jul 23, 2021
fa43626 test_runner: Remove travis specific code (MarcoFalke)

Pull request description:

  The tests are no longer run on travis, but in a docker, developer machines or a windows vm.

  The code was essentially dead for months now. Fix that by explicitly passing in `--ci` to the test runner on our docker and appveyor windows vm.

Tree-SHA512: 5d48693c03e8eb27536658ccf9ba738fe93a72abd4b72c80caac084b5b2cdffa77a1031a671eeefe70b71d63500f55917803d4be54d01849722afdccb700a9e6
Munkybooty added a commit to Munkybooty/dash that referenced this issue Jul 26, 2021
fa43626 test_runner: Remove travis specific code (MarcoFalke)

Pull request description:

  The tests are no longer run on travis, but in a docker, developer machines or a windows vm.

  The code was essentially dead for months now. Fix that by explicitly passing in `--ci` to the test runner on our docker and appveyor windows vm.

Tree-SHA512: 5d48693c03e8eb27536658ccf9ba738fe93a72abd4b72c80caac084b5b2cdffa77a1031a671eeefe70b71d63500f55917803d4be54d01849722afdccb700a9e6
Munkybooty added a commit to Munkybooty/dash that referenced this issue Jul 27, 2021
fa43626 test_runner: Remove travis specific code (MarcoFalke)

Pull request description:

  The tests are no longer run on travis, but in a docker, developer machines or a windows vm.

  The code was essentially dead for months now. Fix that by explicitly passing in `--ci` to the test runner on our docker and appveyor windows vm.

Tree-SHA512: 5d48693c03e8eb27536658ccf9ba738fe93a72abd4b72c80caac084b5b2cdffa77a1031a671eeefe70b71d63500f55917803d4be54d01849722afdccb700a9e6
Munkybooty added a commit to Munkybooty/dash that referenced this issue Jul 28, 2021
fa43626 test_runner: Remove travis specific code (MarcoFalke)

Pull request description:

  The tests are no longer run on travis, but in a docker, developer machines or a windows vm.

  The code was essentially dead for months now. Fix that by explicitly passing in `--ci` to the test runner on our docker and appveyor windows vm.

Tree-SHA512: 5d48693c03e8eb27536658ccf9ba738fe93a72abd4b72c80caac084b5b2cdffa77a1031a671eeefe70b71d63500f55917803d4be54d01849722afdccb700a9e6
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants