Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: Fix a comment #14632

Merged
merged 1 commit into from Nov 5, 2018
Merged

Tests: Fix a comment #14632

merged 1 commit into from Nov 5, 2018

Conversation

fridokus
Copy link
Contributor

@fridokus fridokus commented Nov 1, 2018

Fix a comment that was false

@DrahtBot
Copy link
Contributor

DrahtBot commented Nov 1, 2018 •
edited

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #14606 (Tests: Consistency changes in comments by fridokus)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@DrahtBot DrahtBot mentioned this pull request Nov 1, 2018
Closed
@maflcko
Copy link
Member

maflcko commented Nov 1, 2018

Please keep your commits squashed for trivial changes. See https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits

@fanquake fanquake added the Tests label Nov 1, 2018
@fridokus
Copy link
Contributor Author

fridokus commented Nov 2, 2018

Squashed the commits

@fanquake
Copy link
Member

fanquake commented Nov 5, 2018

utACK 086fc83

maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request Nov 5, 2018
Merge bitcoin#14632: Tests: Fix a comment
6b8d0a2 
086fc83 Tests: Fix a comment (fridokus)

Pull request description:

  Fix a comment that was false

Tree-SHA512: 945aa38229545e026e18c3abf53a4fbe6ec36413ce690fff7a1dd89b6e102d2b574524092e0ddf06cace82f3c040c59221b9b942be1203525814d2fbd50aaa0b
@maflcko maflcko merged commit 086fc83 into bitcoin:master Nov 5, 2018
@fridokus fridokus deleted the typo_fix branch November 6, 2018 09:25
maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request Nov 28, 2018
@raxomukus
Tests: Fix a comment
96f15e8 
Github-Pull: bitcoin#14632
Rebased-From: 086fc83
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Jun 16, 2020
Merge #14632: Tests: Fix a comment
a05bd47 
Summary:
086fc83571 Tests: Fix a comment (fridokus)

Pull request description:

  Fix a comment that was false

Tree-SHA512: 945aa38229545e026e18c3abf53a4fbe6ec36413ce690fff7a1dd89b6e102d2b574524092e0ddf06cace82f3c040c59221b9b942be1203525814d2fbd50aaa0b

Backport of Core [[bitcoin/bitcoin#14632 | PR14632]]

Test Plan: `test_runner.py mempool_resurrect` for sanity

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5900
ftrader pushed a commit to bitcoin-cash-node/bitcoin-cash-node that referenced this pull request Aug 17, 2020
@ftrader
Merge #14632: Tests: Fix a comment
b637a9b 
Summary:
086fc83571 Tests: Fix a comment (fridokus)

Pull request description:

  Fix a comment that was false

Tree-SHA512: 945aa38229545e026e18c3abf53a4fbe6ec36413ce690fff7a1dd89b6e102d2b574524092e0ddf06cace82f3c040c59221b9b942be1203525814d2fbd50aaa0b

Backport of Core [[bitcoin/bitcoin#14632 | PR14632]]

Test Plan: `test_runner.py mempool_resurrect` for sanity

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5900
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 27, 2021
@PastaPastaPasta
Merge bitcoin#14632: Tests: Fix a comment
e6e3bbb 
086fc83 Tests: Fix a comment (fridokus)

Pull request description:

  Fix a comment that was false

Tree-SHA512: 945aa38229545e026e18c3abf53a4fbe6ec36413ce690fff7a1dd89b6e102d2b574524092e0ddf06cace82f3c040c59221b9b942be1203525814d2fbd50aaa0b
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 28, 2021
@PastaPastaPasta
Merge bitcoin#14632: Tests: Fix a comment
5ea1760 
086fc83 Tests: Fix a comment (fridokus)

Pull request description:

  Fix a comment that was false

Tree-SHA512: 945aa38229545e026e18c3abf53a4fbe6ec36413ce690fff7a1dd89b6e102d2b574524092e0ddf06cace82f3c040c59221b9b942be1203525814d2fbd50aaa0b
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 29, 2021
@PastaPastaPasta
Merge bitcoin#14632: Tests: Fix a comment
8207c34 
086fc83 Tests: Fix a comment (fridokus)

Pull request description:

  Fix a comment that was false

Tree-SHA512: 945aa38229545e026e18c3abf53a4fbe6ec36413ce690fff7a1dd89b6e102d2b574524092e0ddf06cace82f3c040c59221b9b942be1203525814d2fbd50aaa0b
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
@PastaPastaPasta
Merge bitcoin#14632: Tests: Fix a comment
7434c41 
086fc83 Tests: Fix a comment (fridokus)

Pull request description:

  Fix a comment that was false

Tree-SHA512: 945aa38229545e026e18c3abf53a4fbe6ec36413ce690fff7a1dd89b6e102d2b574524092e0ddf06cace82f3c040c59221b9b942be1203525814d2fbd50aaa0b
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
@PastaPastaPasta
Merge bitcoin#14632: Tests: Fix a comment
8c791da 
086fc83 Tests: Fix a comment (fridokus)

Pull request description:

  Fix a comment that was false

Tree-SHA512: 945aa38229545e026e18c3abf53a4fbe6ec36413ce690fff7a1dd89b6e102d2b574524092e0ddf06cace82f3c040c59221b9b942be1203525814d2fbd50aaa0b
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
@PastaPastaPasta
Merge bitcoin#14632: Tests: Fix a comment
3d7e6a8 
086fc83 Tests: Fix a comment (fridokus)

Pull request description:

  Fix a comment that was false

Tree-SHA512: 945aa38229545e026e18c3abf53a4fbe6ec36413ce690fff7a1dd89b6e102d2b574524092e0ddf06cace82f3c040c59221b9b942be1203525814d2fbd50aaa0b
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 3, 2021
@PastaPastaPasta
Merge bitcoin#14632: Tests: Fix a comment
befb4d4 
086fc83 Tests: Fix a comment (fridokus)

Pull request description:

  Fix a comment that was false

Tree-SHA512: 945aa38229545e026e18c3abf53a4fbe6ec36413ce690fff7a1dd89b6e102d2b574524092e0ddf06cace82f3c040c59221b9b942be1203525814d2fbd50aaa0b
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maflcko maflcko maflcko left review comments

Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fridokus @DrahtBot @maflcko @fanquake @raxomukus