New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Remove illegal spacing in darwin.mk #14647
Conversation
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
tACK 63c74d2 So However a I assume backward-incompatible changes from 3.82 or 4.0 are the problem. master (b740788):
This PR (63c74d2), using
|
63c74d2 build: Remove illegal spacing in darwin.mk (Jon Layton) Pull request description: MacOS 10.13.6, `make -v` = `GNU Make 4.2.1 Built for x86_64-apple-darwin17.7.0` ``` cd depends make HOST=x86_64-apple-darwin17.7.0 ``` Results in error: ``` builders/darwin.mk:1: *** empty variable name. Stop. ``` This seems to fix it. Tree-SHA512: 3481b9418571186c123942dc95b12bcaf47acbe2099ddd4524f5bb9dfe203175d7252bb7a1aa8ca5fec82578beeacfa06299472cb9d0d627c61f09486d74756c
Backport me? |
Github-Pull: bitcoin#14647 Rebased-From: 63c74d2
Summary: Backport of core [[bitcoin/bitcoin#14647 | PR14647]]. For the sake of avoiding merge conflicts. Test Plan: Untested (by me), I trust the core devs that it is doing something. For what I see it can't hurt. Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D5602
Summary: Backport of core [[bitcoin/bitcoin#14647 | PR14647]]. For the sake of avoiding merge conflicts. Test Plan: Untested (by me), I trust the core devs that it is doing something. For what I see it can't hurt. Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D5602
63c74d2 build: Remove illegal spacing in darwin.mk (Jon Layton) Pull request description: MacOS 10.13.6, `make -v` = `GNU Make 4.2.1 Built for x86_64-apple-darwin17.7.0` ``` cd depends make HOST=x86_64-apple-darwin17.7.0 ``` Results in error: ``` builders/darwin.mk:1: *** empty variable name. Stop. ``` This seems to fix it. Tree-SHA512: 3481b9418571186c123942dc95b12bcaf47acbe2099ddd4524f5bb9dfe203175d7252bb7a1aa8ca5fec82578beeacfa06299472cb9d0d627c61f09486d74756c
63c74d2 build: Remove illegal spacing in darwin.mk (Jon Layton) Pull request description: MacOS 10.13.6, `make -v` = `GNU Make 4.2.1 Built for x86_64-apple-darwin17.7.0` ``` cd depends make HOST=x86_64-apple-darwin17.7.0 ``` Results in error: ``` builders/darwin.mk:1: *** empty variable name. Stop. ``` This seems to fix it. Tree-SHA512: 3481b9418571186c123942dc95b12bcaf47acbe2099ddd4524f5bb9dfe203175d7252bb7a1aa8ca5fec82578beeacfa06299472cb9d0d627c61f09486d74756c
MacOS 10.13.6,
make -v
=GNU Make 4.2.1 Built for x86_64-apple-darwin17.7.0
Results in error:
This seems to fix it.