Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Remove illegal spacing in darwin.mk #14647

Merged
merged 1 commit into from Nov 5, 2018

Conversation

ch4ot1c
Copy link
Contributor

@ch4ot1c ch4ot1c commented Nov 3, 2018

MacOS 10.13.6, make -v = GNU Make 4.2.1 Built for x86_64-apple-darwin17.7.0

cd depends
make HOST=x86_64-apple-darwin17.7.0

Results in error:

builders/darwin.mk:1: *** empty variable name.  Stop.

This seems to fix it.

@DrahtBot
Copy link
Contributor

DrahtBot commented Nov 3, 2018

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

@fanquake
Copy link
Member

fanquake commented Nov 5, 2018

tACK 63c74d2

So depends works fine with the macOS make (GNU Make 3.81, built for i386-apple-darwin11.3.0).

However a brew installed make (GNU Make 4.2.1, built for x86_64-apple-darwin18.0.0), which isgmake here, does not work.

I assume backward-incompatible changes from 3.82 or 4.0 are the problem.

master (b740788):

cd depends
gmake --version
GNU Make 4.2.1

$ gmake -j6
builders/darwin.mk:1: *** empty variable name.  Stop.

This PR (63c74d2), using NO_QT=1 because building qt with newer make is broken, see #14648:

cd depends
gmake NO_QT=1 -j6
.....
Caching miniupnpc...
copying packages: native_biplist native_ds_store native_mac_alias boost openssl libevent zeromq bdb miniupnpc
to: /Users/michael/github/bitcoin/depends/x86_64-apple-darwin18.2.0

@laanwj
Copy link
Member

laanwj commented Nov 5, 2018

utACK 63c74d2, I do not understand why this fixes anything, but will just go with @fanquake's tACK here

@laanwj laanwj merged commit 63c74d2 into bitcoin:master Nov 5, 2018
laanwj added a commit that referenced this pull request Nov 5, 2018
63c74d2 build: Remove illegal spacing in darwin.mk (Jon Layton)

Pull request description:

  MacOS 10.13.6, `make -v` = `GNU Make 4.2.1  Built for x86_64-apple-darwin17.7.0`

  ```
  cd depends
  make HOST=x86_64-apple-darwin17.7.0
  ```
  Results in error:
  ```
  builders/darwin.mk:1: *** empty variable name.  Stop.
  ```

  This seems to fix it.

Tree-SHA512: 3481b9418571186c123942dc95b12bcaf47acbe2099ddd4524f5bb9dfe203175d7252bb7a1aa8ca5fec82578beeacfa06299472cb9d0d627c61f09486d74756c
@gmaxwell
Copy link
Contributor

Backport me?

@maflcko maflcko added this to the 0.17.1 milestone Nov 20, 2018
maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request Nov 28, 2018
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Mar 31, 2020
Summary:
Backport of core [[bitcoin/bitcoin#14647 | PR14647]].

For the sake of avoiding merge conflicts.

Test Plan:
Untested (by me), I trust the core devs that it is doing something. For
what I see it can't hurt.

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5602
ftrader pushed a commit to bitcoin-cash-node/bitcoin-cash-node that referenced this pull request Aug 17, 2020
Summary:
Backport of core [[bitcoin/bitcoin#14647 | PR14647]].

For the sake of avoiding merge conflicts.

Test Plan:
Untested (by me), I trust the core devs that it is doing something. For
what I see it can't hurt.

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5602
UdjinM6 pushed a commit to UdjinM6/dash that referenced this pull request Dec 17, 2020
63c74d2 build: Remove illegal spacing in darwin.mk (Jon Layton)

Pull request description:

  MacOS 10.13.6, `make -v` = `GNU Make 4.2.1  Built for x86_64-apple-darwin17.7.0`

  ```
  cd depends
  make HOST=x86_64-apple-darwin17.7.0
  ```
  Results in error:
  ```
  builders/darwin.mk:1: *** empty variable name.  Stop.
  ```

  This seems to fix it.

Tree-SHA512: 3481b9418571186c123942dc95b12bcaf47acbe2099ddd4524f5bb9dfe203175d7252bb7a1aa8ca5fec82578beeacfa06299472cb9d0d627c61f09486d74756c
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 17, 2021
63c74d2 build: Remove illegal spacing in darwin.mk (Jon Layton)

Pull request description:

  MacOS 10.13.6, `make -v` = `GNU Make 4.2.1  Built for x86_64-apple-darwin17.7.0`

  ```
  cd depends
  make HOST=x86_64-apple-darwin17.7.0
  ```
  Results in error:
  ```
  builders/darwin.mk:1: *** empty variable name.  Stop.
  ```

  This seems to fix it.

Tree-SHA512: 3481b9418571186c123942dc95b12bcaf47acbe2099ddd4524f5bb9dfe203175d7252bb7a1aa8ca5fec82578beeacfa06299472cb9d0d627c61f09486d74756c
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants