Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example_test.py: fixup coinbase height argument, derive number clearly #14664

Merged
merged 1 commit into from Nov 5, 2018

Conversation

Projects
None yet
3 participants
@instagibbs
Copy link
Member

commented Nov 5, 2018

No description provided.

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Nov 5, 2018

utACK 6c5355e

@promag

This comment has been minimized.

Copy link
Member

commented Nov 5, 2018

utACK 6c5355e.

@@ -164,13 +164,13 @@ def run_test(self):
self.tip = int(self.nodes[0].getbestblockhash(), 16)
self.block_time = self.nodes[0].getblock(self.nodes[0].getbestblockhash())['time'] + 1

height = 1
height = self.nodes[0].getblockcount()

This comment has been minimized.

Copy link
@MarcoFalke

MarcoFalke Nov 5, 2018

Member

Actually the + 1 should be suffixed here (similar to block_time above?)

And then remove the change further down?

Suggested change
height = self.nodes[0].getblockcount()
height = self.nodes[0].getblockcount() + 1

This comment has been minimized.

Copy link
@instagibbs

instagibbs Nov 5, 2018

Author Member

2+10=12, and we're waiting for block 11, I'd have to change that too.

This comment has been minimized.

Copy link
@MarcoFalke

MarcoFalke Nov 5, 2018

Member

Ok, fine.

@MarcoFalke MarcoFalke self-assigned this Nov 5, 2018

@MarcoFalke MarcoFalke merged commit 6c5355e into bitcoin:master Nov 5, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

MarcoFalke added a commit that referenced this pull request Nov 5, 2018

Merge #14664: example_test.py: fixup coinbase height argument, derive…
… number clearly

6c5355e example_test.py: fixup coinbase height argument, derive number clearly (Gregory Sanders)

Pull request description:

Tree-SHA512: 52b7eb73422feb1f730924c9f513c1c54e2b8b1bcf962b4df59fb6b0b86812ae8d0d336f8ef8edac9aab0e7722fd16ed21fd92fa58ab143d6f8efc5ac10e5b1f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.