Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example_test.py: fixup coinbase height argument, derive number clearly #14664

Merged
merged 1 commit into from Nov 5, 2018

Conversation

@instagibbs
Copy link
Member

@instagibbs instagibbs commented Nov 5, 2018

No description provided.

@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Nov 5, 2018

utACK 6c5355e

@promag
Copy link
Member

@promag promag commented Nov 5, 2018

utACK 6c5355e.

@@ -164,13 +164,13 @@ def run_test(self):
self.tip = int(self.nodes[0].getbestblockhash(), 16)
self.block_time = self.nodes[0].getblock(self.nodes[0].getbestblockhash())['time'] + 1

height = 1
height = self.nodes[0].getblockcount()
Copy link
Member

@MarcoFalke MarcoFalke Nov 5, 2018

Actually the + 1 should be suffixed here (similar to block_time above?)

And then remove the change further down?

Suggested change
height = self.nodes[0].getblockcount()
height = self.nodes[0].getblockcount() + 1

Copy link
Member Author

@instagibbs instagibbs Nov 5, 2018

2+10=12, and we're waiting for block 11, I'd have to change that too.

Copy link
Member

@MarcoFalke MarcoFalke Nov 5, 2018

Ok, fine.

@MarcoFalke MarcoFalke self-assigned this Nov 5, 2018
@MarcoFalke MarcoFalke merged commit 6c5355e into bitcoin:master Nov 5, 2018
1 of 2 checks passed
MarcoFalke added a commit that referenced this issue Nov 5, 2018
… number clearly

6c5355e example_test.py: fixup coinbase height argument, derive number clearly (Gregory Sanders)

Pull request description:

Tree-SHA512: 52b7eb73422feb1f730924c9f513c1c54e2b8b1bcf962b4df59fb6b0b86812ae8d0d336f8ef8edac9aab0e7722fd16ed21fd92fa58ab143d6f8efc5ac10e5b1f
jasonbcox added a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue Oct 21, 2020
… number clearly

Summary:
6c5355e43d example_test.py: fixup coinbase height argument, derive number clearly (Gregory Sanders)

Backport of Core [[bitcoin/bitcoin#14664 | PR14664]]

Test Plan:
  test_runner.py example_test

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D8033
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 27, 2021
… derive number clearly

6c5355e example_test.py: fixup coinbase height argument, derive number clearly (Gregory Sanders)

Pull request description:

Tree-SHA512: 52b7eb73422feb1f730924c9f513c1c54e2b8b1bcf962b4df59fb6b0b86812ae8d0d336f8ef8edac9aab0e7722fd16ed21fd92fa58ab143d6f8efc5ac10e5b1f
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 28, 2021
… derive number clearly

6c5355e example_test.py: fixup coinbase height argument, derive number clearly (Gregory Sanders)

Pull request description:

Tree-SHA512: 52b7eb73422feb1f730924c9f513c1c54e2b8b1bcf962b4df59fb6b0b86812ae8d0d336f8ef8edac9aab0e7722fd16ed21fd92fa58ab143d6f8efc5ac10e5b1f
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 29, 2021
… derive number clearly

6c5355e example_test.py: fixup coinbase height argument, derive number clearly (Gregory Sanders)

Pull request description:

Tree-SHA512: 52b7eb73422feb1f730924c9f513c1c54e2b8b1bcf962b4df59fb6b0b86812ae8d0d336f8ef8edac9aab0e7722fd16ed21fd92fa58ab143d6f8efc5ac10e5b1f
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jul 1, 2021
… derive number clearly

6c5355e example_test.py: fixup coinbase height argument, derive number clearly (Gregory Sanders)

Pull request description:

Tree-SHA512: 52b7eb73422feb1f730924c9f513c1c54e2b8b1bcf962b4df59fb6b0b86812ae8d0d336f8ef8edac9aab0e7722fd16ed21fd92fa58ab143d6f8efc5ac10e5b1f
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jul 1, 2021
… derive number clearly

6c5355e example_test.py: fixup coinbase height argument, derive number clearly (Gregory Sanders)

Pull request description:

Tree-SHA512: 52b7eb73422feb1f730924c9f513c1c54e2b8b1bcf962b4df59fb6b0b86812ae8d0d336f8ef8edac9aab0e7722fd16ed21fd92fa58ab143d6f8efc5ac10e5b1f
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jul 1, 2021
… derive number clearly

6c5355e example_test.py: fixup coinbase height argument, derive number clearly (Gregory Sanders)

Pull request description:

Tree-SHA512: 52b7eb73422feb1f730924c9f513c1c54e2b8b1bcf962b4df59fb6b0b86812ae8d0d336f8ef8edac9aab0e7722fd16ed21fd92fa58ab143d6f8efc5ac10e5b1f
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jul 3, 2021
… derive number clearly

6c5355e example_test.py: fixup coinbase height argument, derive number clearly (Gregory Sanders)

Pull request description:

Tree-SHA512: 52b7eb73422feb1f730924c9f513c1c54e2b8b1bcf962b4df59fb6b0b86812ae8d0d336f8ef8edac9aab0e7722fd16ed21fd92fa58ab143d6f8efc5ac10e5b1f
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants