Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appveyor: Script improvement part II #14665

Merged
merged 1 commit into from Nov 7, 2018

Conversation

Projects
None yet
7 participants
@ken2812221
Copy link
Member

commented Nov 6, 2018

  • decrease clone depth to 5
  • Upgrade to python 3.7 that we can use PYTHONUTF8 from PEP540.
  • Set clcache version to v4.2.0
  • Do not fetch the latest vcpkg package (The issue does not exist anymore)
  • Set test_bitcoin report sink and log sink to stdout and redirect stderr to NUL to drop confusing error messages that introduced by #14146
  • discard vcpkg, bench_bitcoin output
  • Set functional test --failfast flag
  • Make the log be as clear as possible. (Only ~100 lines)

@fanquake fanquake added the Tests label Nov 6, 2018

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Nov 6, 2018

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #14372 (msvc: build secp256k1 and leveldb locally by ken2812221)
  • #13787 (Test for Windows encoding issue by ken2812221)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Nov 6, 2018

@NicolasDorier

This comment has been minimized.

Copy link
Member

commented Nov 6, 2018

quick review ACK, but will test tomorrow.

@sipsorcery

This comment has been minimized.

Copy link
Contributor

commented Nov 7, 2018

tACK 99d33a6

First build with the updated yaml file failed on the wallet_multiwallet.py test but the two subsequent builds passed. This is most likely a vagary of AppVeyor.

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Nov 7, 2018

Merge bitcoin#14665: appveyor: Script improvement part II
99d33a6 appveyor: Script improvement part II (Chun Kuan Lee)

Pull request description:

  - decrease clone depth to 5
  - Upgrade to python 3.7 that we can use `PYTHONUTF8` from PEP540.
  - Set clcache version to `v4.2.0`
  - Do not fetch the latest vcpkg package (The issue does not exist anymore)
  - Set test_bitcoin report sink and log sink to stdout and redirect stderr to NUL to drop confusing error messages that introduced by bitcoin#14146
  - discard vcpkg, bench_bitcoin output
  - Set functional test `--failfast` flag
  - Make the log be as clear as possible. (Only ~100 lines)

Tree-SHA512: e7e1f5c2698e8a5d15394edfb4b574508081e99ef4a353995f55657cb51e642567a128d6432a899ecae6f742494c143ac16e2e64df6c26e1e575421ee4a1df50

@MarcoFalke MarcoFalke merged commit 99d33a6 into bitcoin:master Nov 7, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ken2812221 ken2812221 deleted the ken2812221:appveyor-quiet branch Nov 7, 2018

- cmd: src\test_bitcoin.exe
- ps: src\bench_bitcoin.exe -evals=1 -scaling=0
- cmd: src\test_bitcoin.exe -k stdout -e stdout 2> NUL
- cmd: src\bench_bitcoin.exe -evals=1 -scaling=0 > NUL

This comment has been minimized.

Copy link
@MarcoFalke

MarcoFalke Dec 17, 2018

Member

This will hide precious debug information in case of failure?

See for example 1a7cebc

This comment has been minimized.

Copy link
@sipa

sipa Dec 17, 2018

Member

@MarcoFalke No, it doesn't seem to. -k stdout is supposed to send the output to stdout anyway. I was just making sure that wasn't the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.