Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: Fail the UBSan Travis build in case of newly introduced UBSan errors #14673

Merged
merged 3 commits into from Nov 6, 2018

Conversation

Projects
None yet
2 participants
@practicalswift
Copy link
Member

commented Nov 6, 2018

Fail the UBSan Travis build in case of newly introduced UBSan (UndefinedBehaviorSanitizer) errors.

Prior to this commit new UBSan errors were printed but didn't fail the UBSan Travis build.

Changes:

  • Travis: Add UBSan options: print_stacktrace + halt_on_error
  • Travis: Add UBSan suppressions needed to pass test suite
  • Travis: Add llvm-symbolizer directory to PATH. Needed to get symbolized stack traces from the sanitizers.

halt_on_error should have been part of #14252 really :-)

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Nov 6, 2018

Tested ACK 4773fa8 (Checked that fced6b5 fails on travis and that 4773fa8 prints more useful stacks)

@MarcoFalke MarcoFalke merged commit 4773fa8 into bitcoin:master Nov 6, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

MarcoFalke added a commit that referenced this pull request Nov 6, 2018

Merge #14673: travis: Fail the UBSan Travis build in case of newly in…
…troduced UBSan errors

4773fa8 Add llvm-symbolizer directory to PATH. Needed to get symbolized stack traces from the sanitizers. (practicalswift)
5c292da Add UBSan suppressions needed to pass test suite (practicalswift)
fced6b5 Add UBSan options: print_stacktrace + halt_on_error (practicalswift)

Pull request description:

  Fail the UBSan Travis build in case of newly introduced [UBSan (UndefinedBehaviorSanitizer)](https://clang.llvm.org/docs/UndefinedBehaviorSanitizer.html) errors.

  Prior to this commit new UBSan errors were printed but didn't fail the UBSan Travis build.

  Changes:
  * Travis: Add UBSan options: `print_stacktrace` + `halt_on_error`
  * Travis: Add UBSan suppressions needed to pass test suite
  * Travis: Add `llvm-symbolizer` directory to PATH. Needed to get symbolized stack traces from the sanitizers.

  `halt_on_error` should have been part of #14252 really :-)

Tree-SHA512: 30e960659196873d4f636f3a61267b8b4441a0e8773e3f3ae4660a9341d028c363636f0cb919ef9d6662ceb484e3d58054adfb6dc76ff8a355a1c9f927c328d1

@MarcoFalke MarcoFalke added the Tests label Nov 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.