Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] conf: Remove deprecated options from docs, Other cleanup #14684

Merged
merged 1 commit into from Nov 8, 2018

Conversation

Projects
None yet
6 participants
@MarcoFalke
Copy link
Member

commented Nov 7, 2018

Some dumb fixes, like removing the mention that free transactions are still a thing or that rpcuser/pass should be used (as opposed to rpcauth or rpc cookie).

Combined with other fixes because I don't want to create 3 pull requests:

  • conf: Remove deprecated options from docs
  • Remove only mention of MIT/X11
  • Link to developer notes in README.md

@MarcoFalke MarcoFalke added the Docs label Nov 7, 2018

Show resolved Hide resolved doc/build-osx.md Outdated
Show resolved Hide resolved doc/build-osx.md Outdated
Show resolved Hide resolved share/examples/bitcoin.conf Outdated
@practicalswift

This comment has been minimized.

Copy link
Member

commented Nov 7, 2018

utACK fac57360d0f1375d8df34c57063d83e30cb5499f modulo nits :-)

@MarcoFalke MarcoFalke force-pushed the MarcoFalke:Mf1609-trivialPre14 branch Nov 7, 2018

Show resolved Hide resolved doc/build-osx.md Outdated
[doc] conf: Remove deprecated options from docs, Other cleanup
* conf: Remove deprecated options from docs
* Remove only mention of MIT/X11
* Link to developer notes in README.md

@MarcoFalke MarcoFalke force-pushed the MarcoFalke:Mf1609-trivialPre14 branch to fa4da3c Nov 7, 2018

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Nov 7, 2018

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

@practicalswift

This comment has been minimized.

Copy link
Member

commented Nov 7, 2018

ACK fa4da3c

@fanquake

This comment has been minimized.

Copy link
Member

commented Nov 8, 2018

utACK fa4da3c

@hebasto

This comment has been minimized.

Copy link
Member

commented Nov 8, 2018

utACK fa4da3c

@promag

This comment has been minimized.

Copy link
Member

commented Nov 8, 2018

utACK fa4da3c.

@MarcoFalke MarcoFalke merged commit fa4da3c into bitcoin:master Nov 8, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

MarcoFalke added a commit that referenced this pull request Nov 8, 2018

Merge #14684: [doc] conf: Remove deprecated options from docs, Other …
…cleanup

fa4da3c [doc] conf: Remove deprecated options from docs, Other cleanup (MarcoFalke)

Pull request description:

  Some dumb fixes, like removing the mention that free transactions are still a thing or that rpcuser/pass should be used (as opposed to rpcauth or rpc cookie).

  Combined with other fixes because I don't want to create 3 pull requests:
  * conf: Remove deprecated options from docs
  * Remove only mention of MIT/X11
  * Link to developer notes in README.md

Tree-SHA512: 9e45dc6c63037e7618cf3c871d7d9e65b66f1a952f91a6e623d97d90171e29bc40299a06029c4dc21a0f579e68021e3663186bd3a65e3ab333aff711f7dcb2bf

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1609-trivialPre14 branch Nov 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.