New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add CLIENT_VERSION_BUILD to CFBundleGetInfoString #14701

Merged
merged 1 commit into from Dec 12, 2018

Conversation

Projects
None yet
4 participants
@fanquake
Copy link
Member

fanquake commented Nov 10, 2018

As mentioned in #14697, if you download the 0.17.0.1 dmg, and inspect the .app bundle, the version in the GetInfo string reads 0.17.0, which is confusing given you're expecting 0.17.0.1:
0 17 0 1

This PR adds CLIENT_VERSION_BUILD to the string, so that the full version number is displayed, i.e:
this pr

@laanwj

This comment has been minimized.

Copy link
Member

laanwj commented Nov 14, 2018

Concept ACK.
Might want to wait until #14612 is merged so that RC level (of appropriate) can be included as well.

@laanwj

This comment has been minimized.

Copy link
Member

laanwj commented Nov 23, 2018

Might want to wait until #14612 is merged so that RC level (of appropriate) can be included as well.

FYI #14612 was merged

@bitcoin bitcoin deleted a comment from DrahtBot Nov 23, 2018

@jonasschnelli

This comment has been minimized.

Copy link
Member

jonasschnelli commented Dec 9, 2018

utACK 8e20934

@jonasschnelli

This comment has been minimized.

Copy link
Member

jonasschnelli commented Dec 10, 2018

Tested via gitian build: https://bitcoin.jonasschnelli.ch/build/908

Result:
bildschirmfoto 2018-12-09 um 14 57 55

@laanwj laanwj merged commit 8e20934 into bitcoin:master Dec 12, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Dec 12, 2018

Merge #14701: build: Add CLIENT_VERSION_BUILD to CFBundleGetInfoString
8e20934 build: Add CLIENT_VERSION_BUILD to CFBundleGetInfoString (fanquake)

Pull request description:

  As mentioned in #14697, if you download the `0.17.0.1` dmg, and inspect the `.app` bundle, the version in the GetInfo string reads `0.17.0`, which is confusing given you're expecting `0.17.0.1`:
  <img width="391" alt="0 17 0 1" src="https://user-images.githubusercontent.com/863730/48300032-fbb54b00-e510-11e8-9bcd-77e1fffffc63.png">

  This PR adds `CLIENT_VERSION_BUILD` to the string, so that the full version number is displayed, i.e:
  <img width="327" alt="this pr" src="https://user-images.githubusercontent.com/863730/48300015-7893f500-e510-11e8-98b9-80424719a082.png">

Tree-SHA512: f553253d03283639cc4dda00c8004b5c63ae2b489762e5e8c666166e71b14e672792c1df678f87484d51d153b5781c5ec1b145774096600f504833024ae8baea

@fanquake fanquake deleted the fanquake:add-build-version-to-info-plist branch Dec 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment