Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: Avoid timeout on verify-commits check #14705

Merged
merged 2 commits into from Nov 13, 2018

Conversation

Projects
None yet
4 participants
@MarcoFalke
Copy link
Member

commented Nov 10, 2018

The verify-commits check is too expensive to run in full (calculate Tree-SHA512 and clean-merge for every single merge commit in history) every day (the cron job runs every ~24h). Since the cron job is running every day, it is also redundant to redo most of the work on the next day.

So, only check two days worth of commits and assume that travis checked the Tree-SHA512 and clean-merge for all other commits already. The script will still check all the signatures, since the check-result for them depends on external inputs such as current time or the public keys we got from the server.

[Note that travis is not meant to do the verification for anyone or is meant to be trusted in any way. This check only serves as a belt-and-suspender to notify maintainers in case of a technical issue or script malfunction. But since the script is timing out for months now, its purpose is diminished right now.]

@MarcoFalke MarcoFalke added the Tests label Nov 10, 2018

@MarcoFalke MarcoFalke force-pushed the MarcoFalke:Mf1811-travisVerifyCommits branch Nov 10, 2018

@MarcoFalke MarcoFalke force-pushed the MarcoFalke:Mf1811-travisVerifyCommits branch Nov 10, 2018

@MarcoFalke MarcoFalke force-pushed the MarcoFalke:Mf1811-travisVerifyCommits branch to fa3df02 Nov 10, 2018

@MarcoFalke

This comment has been minimized.

@ken2812221

This comment has been minimized.

Copy link
Member

commented Nov 10, 2018

utACK fa5a6ce

@sipa

This comment has been minimized.

Copy link
Member

commented Nov 11, 2018

Concept ACK

@promag

This comment has been minimized.

Copy link
Member

commented Nov 12, 2018

utACK fa5a6ce.

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Nov 13, 2018

Merge bitcoin#14705: travis: Avoid timeout on verify-commits check
fa5a6ce qa: Raise ci test_runner timeout to 40 mins (MarcoFalke)
fa3df02 travis: Avoid timeout on verify-commits check (MarcoFalke)

Pull request description:

  The verify-commits check is too expensive to run in full (calculate Tree-SHA512 and clean-merge for every single merge commit in history) every day (the cron job runs every ~24h). Since the cron job is running every day, it is also redundant to redo most of the work on the next day.

  So, only check two days worth of commits and assume that travis checked the Tree-SHA512 and clean-merge for all other commits already. The script will still check all the signatures, since the check-result for them depends on external inputs such as current time or the public keys we got from the server.

  [Note that travis is not meant to do the verification for anyone or is meant to be trusted in any way. This check only serves as a belt-and-suspender to notify maintainers in case of a technical issue or script malfunction. But since the script is timing out for months now, its purpose is diminished right now.]

Tree-SHA512: 336c5cbcc03cdf50be96cd61412471be9078d862da8ba2054f337441e062a6067c95fbbd03912e3de6a116f3caa75fd3f01a04864d34aae1489faa3154572815

@MarcoFalke MarcoFalke merged commit fa5a6ce into bitcoin:master Nov 13, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1811-travisVerifyCommits branch Nov 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.