Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Warn unrecognised sections in the config file #14708
This PR intends to resolve #14702.
In the config file, sections are specified by square bracket pair ""$,
Typicaly, [testnet] is not a correct section name and specified options
So, add some log-warning messages if unrecognized section names are
note: Currentry, followings are out of scope of this PR.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
Nov 16, 2018
Nov 16, 2018
referenced this pull request
Nov 17, 2018
left a comment
I haven't looked at the appveyor failure but it could be caused by static initialization issues based on ordering (a global is initialized on another globals value, but before the other global was initialized). So maybe
Could at least rule that out by trying the refactoring I suggested in this review.