Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: util.h: explicitly include required QString header #14714

Merged
merged 1 commit into from Nov 13, 2018

Conversation

@1Il1
Copy link
Contributor

@1Il1 1Il1 commented Nov 13, 2018

Alternative to #14713.

Instead of depending on clang formatter to not reorder includes, another fix is to explicitly include the missing header file.

@ken2812221
Copy link
Contributor

@ken2812221 ken2812221 commented Nov 13, 2018

utACK 27154ce

@jonasschnelli
Copy link
Contributor

@jonasschnelli jonasschnelli commented Nov 13, 2018

utACK 27154ce
(seems to be the cleaner solution then #14713)

@1Il1
Copy link
Contributor Author

@1Il1 1Il1 commented Nov 13, 2018

@jonasschnelli Agreed. I do think the inability to find the main header file is a problem. There is a "regexp for main header file" configuration option as well. Will look into that.

@Empact
Copy link
Member

@Empact Empact commented Nov 13, 2018

utACK 27154ce

BTW this is the prefered solution as per the developer notes:

Every .cpp and .h file should #include every header file it directly uses classes, functions or other definitions from, even if those headers are already included indirectly through other headers.

Rationale: Excluding headers because they are already indirectly included results in compilation failures when those indirect dependencies change. Furthermore, it obscures what the real code dependencies are.

https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md

@promag
Copy link
Member

@promag promag commented Nov 13, 2018

utACK 27154ce.

@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Nov 13, 2018

utACK 27154ce

Welcome as a contributor @1Il1! :-)

@laanwj
Copy link
Member

@laanwj laanwj commented Nov 13, 2018

I was afraid for a moment and thought you meant the old src/util.h, which definitely shouldn't include Qt headers

utACK 27154ce ofcourse

@laanwj laanwj changed the title util.h: explicitly include required QString header tests: util.h: explicitly include required QString header Nov 13, 2018
@laanwj laanwj merged commit 27154ce into bitcoin:master Nov 13, 2018
2 checks passed
laanwj added a commit that referenced this issue Nov 13, 2018
27154ce util.h: explicitly include required QString header (1Il1)

Pull request description:

  Alternative to #14713.

  Instead of depending on clang formatter to not reorder includes, another fix is to explicitly include the missing header file.

Tree-SHA512: f419ef2fd1dfd8da28160a94d187af78463fb398ef6aadd6c68ebf57e6d02380d93f5f370bf2d39e88dcbfeb252c3e5f245c0a157c7d0a64c38fc0f0c7004515
@1Il1 1Il1 deleted the patch-3 branch Nov 13, 2018
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 27, 2021
27154ce util.h: explicitly include required QString header (1Il1)

Pull request description:

  Alternative to bitcoin#14713.

  Instead of depending on clang formatter to not reorder includes, another fix is to explicitly include the missing header file.

Tree-SHA512: f419ef2fd1dfd8da28160a94d187af78463fb398ef6aadd6c68ebf57e6d02380d93f5f370bf2d39e88dcbfeb252c3e5f245c0a157c7d0a64c38fc0f0c7004515
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 28, 2021
27154ce util.h: explicitly include required QString header (1Il1)

Pull request description:

  Alternative to bitcoin#14713.

  Instead of depending on clang formatter to not reorder includes, another fix is to explicitly include the missing header file.

Tree-SHA512: f419ef2fd1dfd8da28160a94d187af78463fb398ef6aadd6c68ebf57e6d02380d93f5f370bf2d39e88dcbfeb252c3e5f245c0a157c7d0a64c38fc0f0c7004515
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 29, 2021
27154ce util.h: explicitly include required QString header (1Il1)

Pull request description:

  Alternative to bitcoin#14713.

  Instead of depending on clang formatter to not reorder includes, another fix is to explicitly include the missing header file.

Tree-SHA512: f419ef2fd1dfd8da28160a94d187af78463fb398ef6aadd6c68ebf57e6d02380d93f5f370bf2d39e88dcbfeb252c3e5f245c0a157c7d0a64c38fc0f0c7004515
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jul 1, 2021
27154ce util.h: explicitly include required QString header (1Il1)

Pull request description:

  Alternative to bitcoin#14713.

  Instead of depending on clang formatter to not reorder includes, another fix is to explicitly include the missing header file.

Tree-SHA512: f419ef2fd1dfd8da28160a94d187af78463fb398ef6aadd6c68ebf57e6d02380d93f5f370bf2d39e88dcbfeb252c3e5f245c0a157c7d0a64c38fc0f0c7004515
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jul 1, 2021
27154ce util.h: explicitly include required QString header (1Il1)

Pull request description:

  Alternative to bitcoin#14713.

  Instead of depending on clang formatter to not reorder includes, another fix is to explicitly include the missing header file.

Tree-SHA512: f419ef2fd1dfd8da28160a94d187af78463fb398ef6aadd6c68ebf57e6d02380d93f5f370bf2d39e88dcbfeb252c3e5f245c0a157c7d0a64c38fc0f0c7004515
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jul 1, 2021
27154ce util.h: explicitly include required QString header (1Il1)

Pull request description:

  Alternative to bitcoin#14713.

  Instead of depending on clang formatter to not reorder includes, another fix is to explicitly include the missing header file.

Tree-SHA512: f419ef2fd1dfd8da28160a94d187af78463fb398ef6aadd6c68ebf57e6d02380d93f5f370bf2d39e88dcbfeb252c3e5f245c0a157c7d0a64c38fc0f0c7004515
UdjinM6 added a commit to UdjinM6/dash that referenced this issue Jul 5, 2021
27154ce util.h: explicitly include required QString header (1Il1)

Pull request description:

  Alternative to bitcoin#14713.

  Instead of depending on clang formatter to not reorder includes, another fix is to explicitly include the missing header file.

Tree-SHA512: f419ef2fd1dfd8da28160a94d187af78463fb398ef6aadd6c68ebf57e6d02380d93f5f370bf2d39e88dcbfeb252c3e5f245c0a157c7d0a64c38fc0f0c7004515
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants