Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa: Check specific reject reasons in feature_block #14719

Merged
merged 1 commit into from Nov 21, 2018

Conversation

Projects
None yet
2 participants
@MarcoFalke
Copy link
Member

commented Nov 13, 2018

There are some consensus checks that are essentially turned off because we never send the block, but only the header. It happens that the header was sufficient to determine the invalidity of the block according to our consensus rules in those cases. Fix that by forcing the full block on the node unsolicited.

@MarcoFalke MarcoFalke requested a review from sdaftuar Nov 13, 2018

@MarcoFalke MarcoFalke added the Tests label Nov 13, 2018

@laanwj

This comment has been minimized.

Copy link
Member

commented Nov 21, 2018

utACK fa7da06
good catch!

@laanwj laanwj merged commit fa7da06 into bitcoin:master Nov 21, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Nov 21, 2018

Merge #14719: qa: Check specific reject reasons in feature_block
fa7da06 qa: Check specific reject reasons in feature_block (MarcoFalke)

Pull request description:

  There are some consensus checks that are essentially turned off because we never send the block, but only the header. It happens that the header was sufficient to determine the invalidity of the block according to our consensus rules in those cases. Fix that by forcing the full block on the node unsolicited.

Tree-SHA512: a5534318370367ea8de07d853de7e845c8f5637cd6d5457e932a9555af26cc212625e443c00c93586d556cc770f301248e7cabd68131a37791ae91706e7e40b2

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1811-qaRejectBlock branch Nov 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.