Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Improve scripted-diff developer docs #14731

Merged
merged 1 commit into from Nov 16, 2018
Merged

Conversation

@dongcarl
Copy link
Contributor

@dongcarl dongcarl commented Nov 15, 2018

Instead of verifying all scripted-diffs, provide an example that only verifies all scripted-diffs in commits since origin/master.

The scripted-diff is verified by the tool `test/lint/commit-script-check.sh`
The scripted-diff is verified by the tool `test/lint/commit-script-check.sh`. The tool's default behavior when supplied
with a commit is to verify all scripted-diffs since the beginning of time. For development, it might be more convienient
to verify all scripted-diffs in commits since `origin/master`:
Copy link
Member

@MarcoFalke MarcoFalke Nov 15, 2018

Suggested change
to verify all scripted-diffs in commits since `origin/master`:
to verify all scripted-diffs in a range `A..B`, for example:

nit: Not sure if worth changing, but it should accept any range.

@MarcoFalke MarcoFalke changed the title Improve scripted-diff developer docs doc: Improve scripted-diff developer docs Nov 15, 2018
@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Nov 15, 2018

ACK 2734aaf1897b1cb6c0fd73d220980fd698e1b934

@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Nov 15, 2018

ACK 5013895bc9b63ef47462d9f6658e86520d2ac0f5 modulo typo fix

Nice documentation improvement!

the first supplied argument to `git rev-list --reverse` to determine which commits to verify script-diffs for, ignoring
commits that don't conform to the commit message format described above.

For development, it might be more convienient to verify all scripted-diffs in a range `A..B`, for example:
Copy link
Contributor

@practicalswift practicalswift Nov 15, 2018

Convenient :-)

Instead of verifying all scripted-diffs, provide an example that only verifies all scripted-diffs in commits since `origin/master.
@promag
Copy link
Member

@promag promag commented Nov 16, 2018

ACK 07e286d.

@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Nov 16, 2018

ACK 07e286d

MarcoFalke added a commit to MarcoFalke/bitcoin-core that referenced this issue Nov 16, 2018
07e286d Improve scripted-diff developer docs (Carl Dong)

Pull request description:

  Instead of verifying all scripted-diffs, provide an example that only verifies all scripted-diffs in commits since `origin/master`.

Tree-SHA512: 2faecfd1df04046c77ca2b7426675265f7ed656b2b7e2714ae61c0a38b3ea239f35d2be6d615c5191a21f3a453e37f6a4622bd4558173b768cb73183b56c4d62
@MarcoFalke MarcoFalke merged commit 07e286d into bitcoin:master Nov 16, 2018
2 checks passed
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 27, 2021
07e286d Improve scripted-diff developer docs (Carl Dong)

Pull request description:

  Instead of verifying all scripted-diffs, provide an example that only verifies all scripted-diffs in commits since `origin/master`.

Tree-SHA512: 2faecfd1df04046c77ca2b7426675265f7ed656b2b7e2714ae61c0a38b3ea239f35d2be6d615c5191a21f3a453e37f6a4622bd4558173b768cb73183b56c4d62
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 28, 2021
07e286d Improve scripted-diff developer docs (Carl Dong)

Pull request description:

  Instead of verifying all scripted-diffs, provide an example that only verifies all scripted-diffs in commits since `origin/master`.

Tree-SHA512: 2faecfd1df04046c77ca2b7426675265f7ed656b2b7e2714ae61c0a38b3ea239f35d2be6d615c5191a21f3a453e37f6a4622bd4558173b768cb73183b56c4d62
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 29, 2021
07e286d Improve scripted-diff developer docs (Carl Dong)

Pull request description:

  Instead of verifying all scripted-diffs, provide an example that only verifies all scripted-diffs in commits since `origin/master`.

Tree-SHA512: 2faecfd1df04046c77ca2b7426675265f7ed656b2b7e2714ae61c0a38b3ea239f35d2be6d615c5191a21f3a453e37f6a4622bd4558173b768cb73183b56c4d62
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jul 1, 2021
07e286d Improve scripted-diff developer docs (Carl Dong)

Pull request description:

  Instead of verifying all scripted-diffs, provide an example that only verifies all scripted-diffs in commits since `origin/master`.

Tree-SHA512: 2faecfd1df04046c77ca2b7426675265f7ed656b2b7e2714ae61c0a38b3ea239f35d2be6d615c5191a21f3a453e37f6a4622bd4558173b768cb73183b56c4d62
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jul 1, 2021
07e286d Improve scripted-diff developer docs (Carl Dong)

Pull request description:

  Instead of verifying all scripted-diffs, provide an example that only verifies all scripted-diffs in commits since `origin/master`.

Tree-SHA512: 2faecfd1df04046c77ca2b7426675265f7ed656b2b7e2714ae61c0a38b3ea239f35d2be6d615c5191a21f3a453e37f6a4622bd4558173b768cb73183b56c4d62
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jul 1, 2021
07e286d Improve scripted-diff developer docs (Carl Dong)

Pull request description:

  Instead of verifying all scripted-diffs, provide an example that only verifies all scripted-diffs in commits since `origin/master`.

Tree-SHA512: 2faecfd1df04046c77ca2b7426675265f7ed656b2b7e2714ae61c0a38b3ea239f35d2be6d615c5191a21f3a453e37f6a4622bd4558173b768cb73183b56c4d62
UdjinM6 added a commit to UdjinM6/dash that referenced this issue Jul 5, 2021
07e286d Improve scripted-diff developer docs (Carl Dong)

Pull request description:

  Instead of verifying all scripted-diffs, provide an example that only verifies all scripted-diffs in commits since `origin/master`.

Tree-SHA512: 2faecfd1df04046c77ca2b7426675265f7ed656b2b7e2714ae61c0a38b3ea239f35d2be6d615c5191a21f3a453e37f6a4622bd4558173b768cb73183b56c4d62
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants