Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
P2P: Make peer timeout configurable, speed up very slow test and ensure correct code path tested. #14733
Locally verified changes:
With Proposed Change (4.7 sec.):
Currently on master (62.8 sec.):
Error message demonstrated for new argument
I didn't move it into
Thanks for your prompt comments @MarcoFalke - looking forward to any further thoughts!
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
changed the title
p2p: allow p2ptimeout to be configurable, speed up slow test
Nov 19, 2018
dongcarl left a comment •
Question for other reviewers: I'm wondering what the best types are for
I think that while it is logical for these things to be unsigned, and the conversion are largely safe given the current codebase, there are a few things to consider:
Perhaps what should be done is to leave the types alone until we use something like
Really appreciate the great comments.
Let me know how things look from here!