Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Fix running wallet_listtransactions.py individually through test_runner.py #14738

Merged
merged 1 commit into from Dec 29, 2018

Conversation

@kristapsk
Copy link
Contributor

@kristapsk kristapsk commented Nov 16, 2018

As suggested by @MarcoFalke. Resolves #14732.

@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Nov 16, 2018

(en|dis)able_mocktime is now only used for the create_cache util function. Mind inlining it there to make sure it is not called from the outside again?

@kristapsk kristapsk force-pushed the listtransactions branch from 364a877 to 8f4bd56 Nov 16, 2018
@kristapsk
Copy link
Contributor Author

@kristapsk kristapsk commented Nov 16, 2018

Done.

Copy link
Member

@MarcoFalke MarcoFalke left a comment

ACK, beside comments

test/functional/test_framework/test_framework.py Outdated Show resolved Hide resolved
test/functional/test_framework/test_framework.py Outdated Show resolved Hide resolved
test/functional/test_framework/test_framework.py Outdated Show resolved Hide resolved
@kristapsk kristapsk force-pushed the listtransactions branch from 6f65170 to 2474de0 Nov 16, 2018
@kristapsk
Copy link
Contributor Author

@kristapsk kristapsk commented Nov 16, 2018

Ok, changed comments too.

@fanquake fanquake added the Tests label Nov 16, 2018
@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Nov 17, 2018

utACK 2474de0

@kristapsk kristapsk changed the title Fix running wallet_listtransactions.py individually through test_runner.py Tests: Fix running wallet_listtransactions.py individually through test_runner.py Nov 22, 2018
MarcoFalke added a commit to MarcoFalke/bitcoin-core that referenced this issue Dec 29, 2018
…dividually through test_runner.py

2474de0 Fix running individually through test_runner.py, as suggested by @MarcoFalke (bitcoin#14732) (Kristaps Kaupe)

Pull request description:

  As suggested by @MarcoFalke. Resolves bitcoin#14732.

Tree-SHA512: b4e400ba06075e218dbd97d0390845f1c55be42a2b6fd70513381318cfc2693473ba1d0f9d7f379a96939d1960b53801fad7c02e06bddc50c5a835ad024c37ef
@MarcoFalke MarcoFalke merged commit 2474de0 into bitcoin:master Dec 29, 2018
1 check passed
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants