Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Indicate -rpcauth option password hashing alg #14741

Merged
merged 1 commit into from Dec 13, 2018

Conversation

@dongcarl
Copy link
Contributor

@dongcarl dongcarl commented Nov 17, 2018

By indicating the password hashing algorithm, users of bitcoin distributions without the script in share/rpcauth and users who don't want to rely on said script can use alternative means to generate the password hash.

Question for reviewers: perhaps we should also indicate that it is specifically a HMAC-SHA-256 of the UTF-8 encoding of their password?

@fanquake fanquake added the Docs label Nov 17, 2018
doc/man/bitcoind.1 Outdated Show resolved Hide resolved
@dongcarl dongcarl force-pushed the 2018-11-improve-rpcauth-help branch from 914ff8e to f5d6744 Nov 19, 2018
@dongcarl
Copy link
Contributor Author

@dongcarl dongcarl commented Nov 19, 2018

Fixed.

@laanwj
Copy link
Member

@laanwj laanwj commented Nov 21, 2018

utACK

Question for reviewers: perhaps we should also indicate that it is specifically a HMAC-SHA-256 of the UTF-8 encoding of their password?

Maybe in some more detailed spec document, but I don't think the option help is a place to go into such detail. It's consistent with the use of UTF-8 throughout the entire application. Mentioning it for the specific option might make people think "then where should I not use UTF-8?".

@DrahtBot
Copy link
Contributor

@DrahtBot DrahtBot commented Nov 22, 2018

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #14532 (Never bind INADDR_ANY by default, and warn when doing so explicitly by luke-jr)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@dongcarl dongcarl force-pushed the 2018-11-improve-rpcauth-help branch from f5d6744 to dcb70b1 Nov 24, 2018
Copy link
Contributor

@ryanofsky ryanofsky left a comment

utACK dcb70b1. Could add doc: or [doc] prefix to PR description to indicate this a documentation-only change.

@dongcarl dongcarl changed the title Indicate -rpcauth option password hashing alg doc: Indicate -rpcauth option password hashing alg Dec 5, 2018
@fanquake
Copy link
Member

@fanquake fanquake commented Dec 13, 2018

utACK dcb70b1

@laanwj laanwj merged commit dcb70b1 into bitcoin:master Dec 13, 2018
2 checks passed
laanwj added a commit that referenced this issue Dec 13, 2018
dcb70b1 Indicate -rpcauth option password hashing alg (Carl Dong)

Pull request description:

  By indicating the password hashing algorithm, users of bitcoin distributions without the script in `share/rpcauth` and users who don't want to rely on said script can use alternative means to generate the password hash.

  Question for reviewers: perhaps we should also indicate that it is specifically a HMAC-SHA-256 of the _**UTF-8**_ encoding of their password?

Tree-SHA512: 86b546c2e78699fa253da0c1e76b21ef60e9b6a5778826ac5136e764d70e3213044cc05cdb4786ba27968781647c46e358a823bbc2db7d45d041d291ee03b83c
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue Oct 26, 2020
Summary:
dcb70b152292a8df9fe834bacdf231ea848819b1 Indicate -rpcauth option password hashing alg (Carl Dong)

Pull request description:

  By indicating the password hashing algorithm, users of bitcoin distributions without the script in `share/rpcauth` and users who don't want to rely on said script can use alternative means to generate the password hash.

  Question for reviewers: perhaps we should also indicate that it is specifically a HMAC-SHA-256 of the _**UTF-8**_ encoding of their password?

---

Backport of Core [[bitcoin/bitcoin#14741 | PR14741]]

Test Plan:
  ninja

Reviewers: #bitcoin_abc, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D8131
Munkybooty added a commit to Munkybooty/dash that referenced this issue Aug 8, 2021
dcb70b1 Indicate -rpcauth option password hashing alg (Carl Dong)

Pull request description:

  By indicating the password hashing algorithm, users of bitcoin distributions without the script in `share/rpcauth` and users who don't want to rely on said script can use alternative means to generate the password hash.

  Question for reviewers: perhaps we should also indicate that it is specifically a HMAC-SHA-256 of the _**UTF-8**_ encoding of their password?

Tree-SHA512: 86b546c2e78699fa253da0c1e76b21ef60e9b6a5778826ac5136e764d70e3213044cc05cdb4786ba27968781647c46e358a823bbc2db7d45d041d291ee03b83c
Munkybooty added a commit to Munkybooty/dash that referenced this issue Aug 11, 2021
dcb70b1 Indicate -rpcauth option password hashing alg (Carl Dong)

Pull request description:

  By indicating the password hashing algorithm, users of bitcoin distributions without the script in `share/rpcauth` and users who don't want to rely on said script can use alternative means to generate the password hash.

  Question for reviewers: perhaps we should also indicate that it is specifically a HMAC-SHA-256 of the _**UTF-8**_ encoding of their password?

Tree-SHA512: 86b546c2e78699fa253da0c1e76b21ef60e9b6a5778826ac5136e764d70e3213044cc05cdb4786ba27968781647c46e358a823bbc2db7d45d041d291ee03b83c
Munkybooty added a commit to Munkybooty/dash that referenced this issue Aug 11, 2021
dcb70b1 Indicate -rpcauth option password hashing alg (Carl Dong)

Pull request description:

  By indicating the password hashing algorithm, users of bitcoin distributions without the script in `share/rpcauth` and users who don't want to rely on said script can use alternative means to generate the password hash.

  Question for reviewers: perhaps we should also indicate that it is specifically a HMAC-SHA-256 of the _**UTF-8**_ encoding of their password?

Tree-SHA512: 86b546c2e78699fa253da0c1e76b21ef60e9b6a5778826ac5136e764d70e3213044cc05cdb4786ba27968781647c46e358a823bbc2db7d45d041d291ee03b83c
Munkybooty added a commit to Munkybooty/dash that referenced this issue Aug 13, 2021
dcb70b1 Indicate -rpcauth option password hashing alg (Carl Dong)

Pull request description:

  By indicating the password hashing algorithm, users of bitcoin distributions without the script in `share/rpcauth` and users who don't want to rely on said script can use alternative means to generate the password hash.

  Question for reviewers: perhaps we should also indicate that it is specifically a HMAC-SHA-256 of the _**UTF-8**_ encoding of their password?

Tree-SHA512: 86b546c2e78699fa253da0c1e76b21ef60e9b6a5778826ac5136e764d70e3213044cc05cdb4786ba27968781647c46e358a823bbc2db7d45d041d291ee03b83c
Munkybooty added a commit to Munkybooty/dash that referenced this issue Aug 15, 2021
dcb70b1 Indicate -rpcauth option password hashing alg (Carl Dong)

Pull request description:

  By indicating the password hashing algorithm, users of bitcoin distributions without the script in `share/rpcauth` and users who don't want to rely on said script can use alternative means to generate the password hash.

  Question for reviewers: perhaps we should also indicate that it is specifically a HMAC-SHA-256 of the _**UTF-8**_ encoding of their password?

Tree-SHA512: 86b546c2e78699fa253da0c1e76b21ef60e9b6a5778826ac5136e764d70e3213044cc05cdb4786ba27968781647c46e358a823bbc2db7d45d041d291ee03b83c
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants