Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: Do not specify sudo in .travis #14770

Merged
merged 1 commit into from Nov 20, 2018

Conversation

Projects
None yet
5 participants
@scravy
Copy link
Contributor

commented Nov 20, 2018

Travis is deprecating the sudo keyword and moves everything to
the same infrastructure (sudo really selects between two infrastructures).

See https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration?utm_source=in-app&utm_medium=intercom for more info.

Do not specify sudo in .travis
Travis is deprecating the `sudo` keyword and moves everything to
the same infrastructure (sudo really selects between two infrastructures).

See https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration?utm_source=in-app&utm_medium=intercom for more info.

@fanquake fanquake added the Tests label Nov 20, 2018

@scravy scravy changed the title Do not specify sudo in .travis travis: Do not specify sudo in .travis Nov 20, 2018

@practicalswift

This comment has been minimized.

Copy link
Member

commented Nov 20, 2018

utACK feeef7d

@laanwj

This comment has been minimized.

Copy link
Member

commented Nov 20, 2018

looks like the sudo: required was explicitly added in 149641e (#7487) to switch to the other infrastructure

now that we're running the tests in docker I doubt this is needed anymore, so concept ACK

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Nov 20, 2018

sudo will still be required, but now that it is the default (and only option available) it makes it redundant.

ACK

@laanwj laanwj merged commit feeef7d into bitcoin:master Nov 20, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Nov 20, 2018

Merge #14770: travis: Do not specify sudo in .travis
feeef7d Do not specify sudo in .travis (Julian Fleischer)

Pull request description:

  Travis is deprecating the `sudo` keyword and moves everything to
  the same infrastructure (sudo really selects between two infrastructures).

  See https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration?utm_source=in-app&utm_medium=intercom for more info.

Tree-SHA512: 3364fbeaf7af5e91ef97cf7fbcc75427ecb4e10b02a31cbc17ccc46a6077bba7a000539717bb6a351c404a2b408af7de6c4587089b02367e67e1c8bfd8fe69d1

@scravy scravy deleted the scravy:patch-1 branch Nov 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.