Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts: Fix detection of copyright holders #14785

Merged
merged 1 commit into from Nov 23, 2018

Conversation

@cornelius
Copy link
Contributor

@cornelius cornelius commented Nov 22, 2018

Fix copyright holder detection so that copyright_header.py report creates a clean and accurate report:

  • Fix list of copyright holders in the code
  • Also detect copyrights which have a comma after the date
  • Exclude directories which are git subtrees
@scravy
Copy link
Contributor

@scravy scravy commented Nov 22, 2018

utACK 89104ef98f882c24695043b74feec2b9d0d8496f

very nice change, the EXCLUDE_DIRS one.

scravy
scravy approved these changes Nov 22, 2018
@cornelius
Copy link
Contributor Author

@cornelius cornelius commented Nov 22, 2018

The failing test doesn't seem to be related to the code changes. It also does work locally.

@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Nov 22, 2018

utACK 89104ef98f882c24695043b74feec2b9d0d8496f

@fanquake
Copy link
Member

@fanquake fanquake commented Nov 23, 2018

utACK 89104ef

1 similar comment
@Empact
Copy link
Member

@Empact Empact commented Nov 23, 2018

utACK 89104ef

@laanwj
Copy link
Member

@laanwj laanwj commented Nov 23, 2018

utACK, but yes makes sense to address @practicalswift 's comment wrt overwriting internal functions.

@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Nov 23, 2018

utACK da9c379c4fafd5e39566a2014777513e87f5fb39

@laanwj
Copy link
Member

@laanwj laanwj commented Nov 23, 2018

utACK after squashing commits

* There is a copyright notice in `src/crypto/sha256_sse4.cpp` in the
  middle of the file which contains a comma before the copyright
  holder name. Correctly detect this so it's added to the report.
* Add missing copyright holders so that `copyright_header.py report`
  doesn't show any unexpected copyright holder names anymore.
* Exclude files from git subtrees because they are maintained at the
  original source.
@cornelius cornelius force-pushed the copyright-header branch from da9c379 to af9a991 Nov 23, 2018
@cornelius
Copy link
Contributor Author

@cornelius cornelius commented Nov 23, 2018

Squashed commits

@scravy scravy mentioned this pull request Nov 23, 2018
3 tasks
@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Nov 23, 2018

Someone could probably bump the headers at this time of the year...

@MarcoFalke MarcoFalke merged commit af9a991 into bitcoin:master Nov 23, 2018
2 checks passed
MarcoFalke added a commit that referenced this issue Nov 23, 2018
af9a991 Fix detection of copyright holders (Cornelius Schumacher)

Pull request description:

  Fix copyright holder detection so that `copyright_header.py report` creates a clean and accurate report:

  * Fix list of copyright holders in the code
  * Also detect copyrights which have a comma after the date
  * Exclude directories which are git subtrees

Tree-SHA512: 7ab78618aa62c7d40b6688ddcde4a85c6fc5df8275271fa85518e146c1db90760bfafaa6036b9f6afbe887fd7e9274c913786101668573a3e289b3411aa6842f
cornelius added a commit to dtr-org/unit-e that referenced this issue Nov 27, 2018
Forward port of changes done in response to feedback on upstream
pull request bitcoin/bitcoin#14785

Signed-off-by: Cornelius Schumacher <cornelius@thirdhash.com>
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue Feb 1, 2021
Summary:
af9a9918b2 Fix detection of copyright holders (Cornelius Schumacher)

Pull request description:

  Fix copyright holder detection so that `copyright_header.py report` creates a clean and accurate report:

  * Fix list of copyright holders in the code
  * Also detect copyrights which have a comma after the date
  * Exclude directories which are git subtrees

---

Backport of Core [[bitcoin/bitcoin#14785 | PR14785]]

Test Plan:
  run it, check results

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D9114
kittywhiskers added a commit to kittywhiskers/dash that referenced this issue Jul 4, 2021
kittywhiskers added a commit to kittywhiskers/dash that referenced this issue Jul 9, 2021
kittywhiskers added a commit to kittywhiskers/dash that referenced this issue Jul 11, 2021
kittywhiskers added a commit to kittywhiskers/dash that referenced this issue Jul 11, 2021
PastaPastaPasta added a commit to dashpay/dash that referenced this issue Jul 13, 2021
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants