Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts: Fix detection of copyright holders #14785

Merged
merged 1 commit into from Nov 23, 2018

Conversation

Projects
None yet
7 participants
@cornelius
Copy link
Contributor

commented Nov 22, 2018

Fix copyright holder detection so that copyright_header.py report creates a clean and accurate report:

  • Fix list of copyright holders in the code
  • Also detect copyrights which have a comma after the date
  • Exclude directories which are git subtrees
@scravy

This comment has been minimized.

Copy link
Contributor

commented Nov 22, 2018

utACK 89104ef98f882c24695043b74feec2b9d0d8496f

very nice change, the EXCLUDE_DIRS one.

@scravy

scravy approved these changes Nov 22, 2018

@cornelius

This comment has been minimized.

Copy link
Contributor Author

commented Nov 22, 2018

The failing test doesn't seem to be related to the code changes. It also does work locally.

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Nov 22, 2018

utACK 89104ef98f882c24695043b74feec2b9d0d8496f

@fanquake

This comment has been minimized.

Copy link
Member

commented Nov 23, 2018

utACK 89104ef

1 similar comment
@Empact

This comment has been minimized.

Copy link
Member

commented Nov 23, 2018

utACK 89104ef

Show resolved Hide resolved contrib/devtools/copyright_header.py Outdated
@laanwj

This comment has been minimized.

Copy link
Member

commented Nov 23, 2018

utACK, but yes makes sense to address @practicalswift 's comment wrt overwriting internal functions.

@practicalswift

This comment has been minimized.

Copy link
Member

commented Nov 23, 2018

utACK da9c379c4fafd5e39566a2014777513e87f5fb39

@laanwj

This comment has been minimized.

Copy link
Member

commented Nov 23, 2018

utACK after squashing commits

Fix detection of copyright holders
* There is a copyright notice in `src/crypto/sha256_sse4.cpp` in the
  middle of the file which contains a comma before the copyright
  holder name. Correctly detect this so it's added to the report.
* Add missing copyright holders so that `copyright_header.py report`
  doesn't show any unexpected copyright holder names anymore.
* Exclude files from git subtrees because they are maintained at the
  original source.

@cornelius cornelius force-pushed the cornelius:copyright-header branch to af9a991 Nov 23, 2018

@cornelius

This comment has been minimized.

Copy link
Contributor Author

commented Nov 23, 2018

Squashed commits

@scravy scravy referenced this pull request Nov 23, 2018

Merged

License headers #214

3 of 3 tasks complete
@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Nov 23, 2018

Someone could probably bump the headers at this time of the year...

@MarcoFalke MarcoFalke merged commit af9a991 into bitcoin:master Nov 23, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

MarcoFalke added a commit that referenced this pull request Nov 23, 2018

Merge #14785: Scripts: Fix detection of copyright holders
af9a991 Fix detection of copyright holders (Cornelius Schumacher)

Pull request description:

  Fix copyright holder detection so that `copyright_header.py report` creates a clean and accurate report:

  * Fix list of copyright holders in the code
  * Also detect copyrights which have a comma after the date
  * Exclude directories which are git subtrees

Tree-SHA512: 7ab78618aa62c7d40b6688ddcde4a85c6fc5df8275271fa85518e146c1db90760bfafaa6036b9f6afbe887fd7e9274c913786101668573a3e289b3411aa6842f

cornelius added a commit to dtr-org/unit-e that referenced this pull request Nov 27, 2018

Don't shadow built-in keyword (#306)
Forward port of changes done in response to feedback on upstream
pull request bitcoin/bitcoin#14785

Signed-off-by: Cornelius Schumacher <cornelius@thirdhash.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.