Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Add AddressSanitizer (ASan) Travis build #14794

Merged
merged 3 commits into from Nov 27, 2018

Conversation

Projects
None yet
4 participants
@practicalswift
Copy link
Member

commented Nov 23, 2018

Add ASan Travis build.

Show resolved Hide resolved .travis.yml Outdated

@fanquake fanquake added the Tests label Nov 23, 2018

@sipa

This comment has been minimized.

Copy link
Member

commented Nov 24, 2018

Any reason to not enable ASan and UBSan in the same test?

@practicalswift practicalswift force-pushed the practicalswift:asan-in-travis branch 3 times, most recently Nov 25, 2018

Show resolved Hide resolved test/functional/p2p_invalid_messages.py Outdated
Show resolved Hide resolved .travis/test_04_install.sh Outdated

@practicalswift practicalswift force-pushed the practicalswift:asan-in-travis branch 7 times, most recently Nov 25, 2018

@practicalswift practicalswift changed the title [wip] Add ASan Travis build Add ASan Travis build Nov 26, 2018

@practicalswift

This comment has been minimized.

Copy link
Member Author

commented Nov 26, 2018

@sipa I was afraid the combined runtime would be too long, but it appears to work. The two Travis jobs have now been merged. Please review.

@MarcoFalke Now running also with LSan (LeakSanitizer). Please review :-)

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Nov 26, 2018

Could squash everything except the changes in test/functional?

@practicalswift practicalswift changed the title Add ASan Travis build Add AddressSanitizer (ASan) Travis build Nov 26, 2018

@practicalswift practicalswift force-pushed the practicalswift:asan-in-travis branch Nov 26, 2018

@practicalswift

This comment has been minimized.

Copy link
Member Author

commented Nov 26, 2018

@MarcoFalke Done! Please re-review :-)

Show resolved Hide resolved test/sanitizer_suppressions/lsan

@MarcoFalke MarcoFalke changed the title Add AddressSanitizer (ASan) Travis build tests: Add AddressSanitizer (ASan) Travis build Nov 26, 2018

@practicalswift

This comment has been minimized.

Copy link
Member Author

commented Nov 26, 2018

@MarcoFalke Added comments as suggested. Please re-review :-)

@practicalswift practicalswift force-pushed the practicalswift:asan-in-travis branch Nov 26, 2018

@practicalswift practicalswift force-pushed the practicalswift:asan-in-travis branch Nov 26, 2018

Show resolved Hide resolved test/sanitizer_suppressions/lsan Outdated

@practicalswift practicalswift force-pushed the practicalswift:asan-in-travis branch 2 times, most recently Nov 26, 2018

@practicalswift practicalswift force-pushed the practicalswift:asan-in-travis branch to 6541d59 Nov 26, 2018

@MarcoFalke MarcoFalke merged commit 6541d59 into bitcoin:master Nov 27, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

MarcoFalke added a commit that referenced this pull request Nov 27, 2018

Merge #14794: tests: Add AddressSanitizer (ASan) Travis build
6541d59 Add LSan suppression warnings (practicalswift)
ff7212e Add ASan Travis build (practicalswift)
ebd3bf2 Make test p2p_invalid_messages.py pass: Allow for expected Travis ASAN memory increase (practicalswift)

Pull request description:

  Add ASan Travis build.

Tree-SHA512: b9712aaf0c9112b637b6ef0c5d93961863dcbecaf31d9561eb09258a61540fb31d2c8ecae86518a82763279e4aa6cac266cd352c2b2507df0335c0199f8b3d78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.