Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt: Use window() instead of obsolete topLevelWidget() #14801

Merged
merged 1 commit into from Dec 9, 2018

Conversation

Projects
None yet
7 participants
@hebasto
Copy link
Member

commented Nov 25, 2018

@fanquake fanquake added the GUI label Nov 25, 2018

@practicalswift

This comment has been minimized.

Copy link
Member

commented Nov 25, 2018

Concept ACK

@fanquake

This comment has been minimized.

Copy link
Member

commented Nov 26, 2018

utACK 0b4a578

Looking at qwidget.h in depends (5.9.6):

QWidget *window() const;
QWidget *nativeParentWidget() const;
inline QWidget *topLevelWidget() const { return window(); }

Also checked that there are no more usages of topLevelWidget in the code base.

@MarcoFalke MarcoFalke added this to the 0.18.0 milestone Nov 26, 2018

@promag

This comment has been minimized.

Copy link
Member

commented Nov 27, 2018

ACK 0b4a578.

@ken2812221

This comment has been minimized.

Copy link
Member

commented Nov 30, 2018

tACK 0b4a578

@laanwj laanwj merged commit 0b4a578 into bitcoin:master Dec 9, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Dec 9, 2018

Merge #14801: qt: Use window() instead of obsolete topLevelWidget()
0b4a578 Use window() instead of obsolete topLevelWidget() (Hennadii Stepanov)

Pull request description:

  `QWidget::topLevelWidget()` is obsolete since at least Qt 4.8.

  Refs:
  - https://doc-snapshots.qt.io/4.8/qwidget-obsolete.html#topLevelWidget
  - https://doc.qt.io/qt-5.9/qwidget-obsolete.html#topLevelWidget

Tree-SHA512: 45a79a3f11acd24bbf335603e60cb46545f4c9ce9b16280117676797a611c4422525abd39ad6784a7bc459926e3f5120b49a170403ff60ba4788d679862e3ff0

@hebasto hebasto deleted the hebasto:20181125-obsolete-toplevelwidget branch Dec 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.