Mining: Enforce that segwit option must be set in GBT #14811
Calling getblocktemplate without the segwit rule specified is most
Of the previous 1000 blocks (measured at block 551591 (hash 0x...173c811)), 991 included segwit transactions.
The text was updated successfully, but these errors were encountered:
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
d2ce315 [docs] add release note for change to GBT (John Newbery) 0025c9e [mining] segwit option must be set in GBT (John Newbery) Pull request description: Calling getblocktemplate without the segwit rule specified is most likely a client error, since it results in lower fees for the miner. Prevent this client error by failing getblocktemplate if called without the segwit rule specified. Of the previous 1000 blocks (measured at block [551591 (hash 0x...173c811)](https://blockstream.info/block/000000000000000000173c811e79858808abc3216af607035973f002bef60a7a)), 991 included segwit transactions. Tree-SHA512: 7933b073d72683c9ab9318db46a085ec19a56a14937945c73f783ac7656887619a86b74db0bdfcb8121df44f63a1d6a6fb19e98505b2a26a6a8a6e768e442fee
Upstream Bitcoin contains a change (bitcoin/bitcoin#14811) that forces miners calling getblocktemplate to indicate segwit support. This is not an issue for Namecoin, though, since this is just about giving miners the option to opt-out of segwit *once activated*. Until activation, segwit transactions will still be ignored, independently of the choice made for getblocktemplate.