New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: test/functional/rpc_psbt: Remove check for specific error message that depends on uncertain assumptions #14818

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@luke-jr
Copy link
Member

luke-jr commented Nov 27, 2018

When converttopsbt is called with a signed transaction, it either fails with "TX decode failed" if one or more inputs were segwit, or "Inputs must not have scriptSigs and scriptWitnesses" otherwise.
Since no effort is made by the test to ensure the inputs are segwit or not, avoid checking the exact message used.
The error code is still checked to ensure it is of the correct kind of failure.

luke-jr added some commits Nov 27, 2018

Bugfix: test/functional/rpc_psbt: Remove check for specific error mes…
…sage that depends on uncertain assumptions

When converttopsbt is called with a signed transaction, it either fails with "TX decode failed" if one or more inputs were segwit, or "Inputs must not have scriptSigs and scriptWitnesses" otherwise.
Since no effort is made by the test to ensure the inputs are segwit or not, avoid checking the exact message used.
The error code is still checked to ensure it is of the correct kind of failure.

@MarcoFalke MarcoFalke requested a review from instagibbs Nov 27, 2018

@MarcoFalke

This comment has been minimized.

Copy link
Member

MarcoFalke commented Nov 27, 2018

Fixes: #13738

@instagibbs

This comment has been minimized.

Copy link
Member

instagibbs commented Nov 27, 2018

didn't know you could give an empty string

utACK c87fc71

@luke-jr

This comment has been minimized.

Copy link
Member

luke-jr commented Nov 27, 2018

I'm not sure it fixes #13738. Isn't that a "no exception thrown" issue? The bug fixed here is that it's throwing a different exception...

@MarcoFalke

This comment has been minimized.

Copy link
Member

MarcoFalke commented Nov 27, 2018

@luke-jr Right

@achow101

This comment has been minimized.

Copy link
Member

achow101 commented Nov 27, 2018

utACK c87fc71

@MarcoFalke MarcoFalke added the Tests label Nov 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment