New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: test/functional/mempool_accept: Ensure oversize transaction is actually oversize #14819

Merged
merged 1 commit into from Nov 28, 2018

Conversation

Projects
None yet
4 participants
@luke-jr
Copy link
Member

luke-jr commented Nov 27, 2018

Simply integer dividing results in an acceptable size if the limit isn't an exact multiple of the input size.
Use math.ceil to ensure the transaction is always oversize.

(This issue can be triggered by changing the address style used.)

Bugfix: test/functional/mempool_accept: Ensure oversize transaction i…
…s actually oversize

Simply integer dividing results in an acceptable size if the limit isn't an exact multiple of the input size.
Use math.ceil to ensure the transaction is always oversize.

@MarcoFalke MarcoFalke added this to the 0.18.0 milestone Nov 27, 2018

@MarcoFalke

This comment has been minimized.

Copy link
Member

MarcoFalke commented Nov 27, 2018

utACK 29aeed1 (I think I left it out back then because it was working already without the math import)

@fanquake fanquake added the Tests label Nov 27, 2018

@promag
Copy link
Member

promag left a comment

utACK 29aeed1.

@@ -5,6 +5,7 @@
"""Test mempool acceptance of raw transactions."""

from io import BytesIO
import math

This comment has been minimized.

@promag

promag Nov 28, 2018

Member

nit from math import ceil?

@MarcoFalke MarcoFalke merged commit 29aeed1 into bitcoin:master Nov 28, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

MarcoFalke added a commit that referenced this pull request Nov 28, 2018

Merge #14819: Bugfix: test/functional/mempool_accept: Ensure oversize…
… transaction is actually oversize

29aeed1 Bugfix: test/functional/mempool_accept: Ensure oversize transaction is actually oversize (Luke Dashjr)

Pull request description:

  Simply integer dividing results in an acceptable size if the limit isn't an exact multiple of the input size.
  Use math.ceil to ensure the transaction is always oversize.

  (This issue can be triggered by changing the address style used.)

Tree-SHA512: e45062b0e8a3e9cb08e9dac5275b68d86e4377b460f1b3b995944090a055b0542a6986826312ec0e223369838094e42e20d8614b5c2bab9975b9a6f749295b21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment