Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix descriptor_tests not checking ToString output of public descriptors #14820

Merged
merged 1 commit into from Nov 27, 2018

Conversation

Projects
None yet
4 participants
@ryanofsky
Copy link
Contributor

commented Nov 27, 2018

This fixes a minor test bug introduced in #13697 that I noticed while reviewing #14646

@sipa

This comment has been minimized.

Copy link
Member

commented Nov 27, 2018

utACK

@MarcoFalke MarcoFalke changed the title Fix descriptor_tests not checking ToString output of public descriptors test: Fix descriptor_tests not checking ToString output of public descriptors Nov 27, 2018

@MarcoFalke MarcoFalke added the Tests label Nov 27, 2018

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Nov 27, 2018

Merge bitcoin#14820: test: Fix descriptor_tests not checking ToString…
… output of public descriptors

c77f092 Fix descriptor_tests not checking ToString output of public descriptors (Russell Yanofsky)

Pull request description:

  This fixes a minor test bug introduced in bitcoin#13697 that I noticed while reviewing bitcoin#14646

Tree-SHA512: efed91200cdff5f86ba5de3461ac00759d285e2905f6cb24cea15d3e23e0581ce5fc14b24a40db093f7ebd662ee1ee2cf67f8798bac1903a78298eda08909cfb
@Empact

This comment has been minimized.

Copy link
Member

commented Nov 27, 2018

utACK

@MarcoFalke MarcoFalke merged commit c77f092 into bitcoin:master Nov 27, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.