Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench: Destroy wallet txs instead of leaking their memory #14822

Merged
merged 1 commit into from Nov 28, 2018

Conversation

Projects
None yet
7 participants
@MarcoFalke
Copy link
Member

commented Nov 27, 2018

This should destroy the wallet txs when the benchmark ends to avoid having to hold them when the following benchmarks run.

@practicalswift

This comment has been minimized.

Copy link
Member

commented Nov 27, 2018

Concept ACK

Thanks for doing this. Nice to get rid of the need for suppressions for this leak in LSAN, Valgrind, etc.

@kallewoof
Copy link
Member

left a comment

utACK fa5cef0

LGTM!

@ken2812221
Copy link
Member

left a comment

utACK fa5cef0

@gmaxwell

This comment has been minimized.

Copy link
Member

commented Nov 28, 2018

utACK.

@meshcollider

This comment has been minimized.

Copy link
Member

commented Nov 28, 2018

utACK fa5cef0

@promag

This comment has been minimized.

Copy link
Member

commented Nov 28, 2018

utACK fa5cef0.

@MarcoFalke MarcoFalke merged commit fa5cef0 into bitcoin:master Nov 28, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

MarcoFalke added a commit that referenced this pull request Nov 28, 2018

Merge #14822: bench: Destroy wallet txs instead of leaking their memory
fa5cef0 bench: Destroy wallet txs instead of leaking their memory (MarcoFalke)

Pull request description:

  This should destroy the wallet txs when the benchmark ends to avoid having to hold them when the following benchmarks run.

Tree-SHA512: e2510946e6a47fad3ec5fb28d298df8ddc2e017455fcff777fa7bbc12d801c08739db6a7a7289509aaa881ccdc59dfff9bcb6772b48db2c457d3787081a46c06

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1811-benchWalletTxs branch Nov 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.