Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate libconsensus linking in test make #14840

Merged
merged 1 commit into from Dec 4, 2018
Merged

Remove duplicate libconsensus linking in test make #14840

merged 1 commit into from Dec 4, 2018

Conversation

@AmirAbrams
Copy link
Contributor

@AmirAbrams AmirAbrams commented Nov 29, 2018

LIBBITCOIN_CONSENSUS is linked twice in Makefile.test.include

LIBBITCOIN_CONSENSUS is linked twice in Makefile.test.include
@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Nov 29, 2018

utACK b14948e

@Duality-CDOO
Copy link

@Duality-CDOO Duality-CDOO commented Nov 30, 2018

Nice catch utACK!

@promag
Copy link
Member

@promag promag commented Nov 30, 2018

utACK b14948e.

@DrahtBot
Copy link
Contributor

@DrahtBot DrahtBot commented Nov 30, 2018

Gitian builds for commit 60b20c8 (master):

Gitian builds for commit 8c5be0cdf7af87f5d256b549837816ab9447a127 (master and this pull):

@Empact
Copy link
Member

@Empact Empact commented Dec 4, 2018

utACK b14948e

@laanwj laanwj merged commit b14948e into bitcoin:master Dec 4, 2018
2 checks passed
laanwj added a commit that referenced this issue Dec 4, 2018
b14948e Remove duplicate libconsensus linking in test make (Amir Abrams)

Pull request description:

  `LIBBITCOIN_CONSENSUS` is linked twice in Makefile.test.include

Tree-SHA512: d4240e6f15f62ec1500021760af5155c6ce3898d1ca8da463ad85e2bff4435aa3b9204505ef889149509ae959d44dd845914671bc3d7df61e89aa3ab5e1aa751
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

9 participants