Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate libconsensus linking in test make #14840

Merged
merged 1 commit into from Dec 4, 2018

Conversation

Projects
None yet
9 participants
@AmirAbrams
Copy link
Contributor

commented Nov 29, 2018

LIBBITCOIN_CONSENSUS is linked twice in Makefile.test.include

Remove duplicate libconsensus linking in test make
LIBBITCOIN_CONSENSUS is linked twice in Makefile.test.include
@practicalswift

This comment has been minimized.

Copy link
Member

commented Nov 29, 2018

utACK b14948e

@Duality-CDOO

This comment has been minimized.

Copy link

commented Nov 30, 2018

Nice catch utACK!

@promag

This comment has been minimized.

Copy link
Member

commented Nov 30, 2018

utACK b14948e.

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Nov 30, 2018

Gitian builds for commit 60b20c8 (master):

Gitian builds for commit 8c5be0cdf7af87f5d256b549837816ab9447a127 (master and this pull):

@Empact

This comment has been minimized.

Copy link
Member

commented Dec 4, 2018

utACK b14948e

@laanwj laanwj merged commit b14948e into bitcoin:master Dec 4, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Dec 4, 2018

Merge #14840: Remove duplicate libconsensus linking in test make
b14948e Remove duplicate libconsensus linking in test make (Amir Abrams)

Pull request description:

  `LIBBITCOIN_CONSENSUS` is linked twice in Makefile.test.include

Tree-SHA512: d4240e6f15f62ec1500021760af5155c6ce3898d1ca8da463ad85e2bff4435aa3b9204505ef889149509ae959d44dd845914671bc3d7df61e89aa3ab5e1aa751
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.