Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
test: Correct ineffectual WithOrVersion from transactions_tests #14855
Dropped the 0-version test as there is no version-specific behavior in transaction serialization, and if there were, does not seem this would be the place to test it.
Maybe you can weigh in on: is it necessary to do this serialization round-trip at all? Could instantiate the tx from the mtx directly.
The version is used on https://github.com/bitcoin/bitcoin/blob/master/src/primitives/transaction.h#L200
I speculate that the intention of the
The roundtrip itself is just used to convert a
It is safe to drop the 0-version test.
@MarcoFalke yes, that's why I said
Then it was refactored for having witness in PROTOCOL_VERSION + a flag to disable witness. Unsure if it was before the merge or after the merge that this was refactored, but I am now almost sure it was the initial reason behind this weird code.