Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet_keypool_topup.py: Test for all keypool address types #14857

Merged
merged 1 commit into from Dec 11, 2018

Conversation

Projects
None yet
6 participants
@instagibbs
Copy link
Member

commented Dec 2, 2018

To protect against regressions if key scanning is changed.

@fanquake fanquake added the Tests label Dec 2, 2018

Show resolved Hide resolved test/functional/wallet_keypool_topup.py Outdated
Show resolved Hide resolved test/functional/wallet_keypool_topup.py Outdated
@promag
Copy link
Member

left a comment

utACK.

@MarcoFalke
Copy link
Member

left a comment

The test is testing nothing

Show resolved Hide resolved test/functional/wallet_keypool_topup.py Outdated

@instagibbs instagibbs force-pushed the instagibbs:keypool_topup_addresstype branch to 0dcac51 Dec 3, 2018

@instagibbs

This comment has been minimized.

Copy link
Member Author

commented Dec 3, 2018

Tested that the returned addresses appear to be the expected type.

@meshcollider

This comment has been minimized.

Copy link
Member

commented Dec 11, 2018

utACK 0dcac51

@MarcoFalke MarcoFalke merged commit 0dcac51 into bitcoin:master Dec 11, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

MarcoFalke added a commit that referenced this pull request Dec 11, 2018

Merge #14857: wallet_keypool_topup.py: Test for all keypool address t…
…ypes

0dcac51 wallet_keypool_topup.py: Test for all keypool address types (Gregory Sanders)

Pull request description:

  To protect against regressions if key scanning is changed.

Tree-SHA512: d1c4bb033bafd97203a3f68fb262a501442be947907d67902f0391fbdec39c095196403c7675e602806cc68d7e2d1f552ab339a58346162379978d06dad1c4bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.