Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet_keypool_topup.py: Test for all keypool address types #14857

Merged
merged 1 commit into from Dec 11, 2018

Conversation

@instagibbs
Copy link
Member

@instagibbs instagibbs commented Dec 2, 2018

To protect against regressions if key scanning is changed.

@fanquake fanquake added the Tests label Dec 2, 2018
test/functional/wallet_keypool_topup.py Outdated Show resolved Hide resolved
test/functional/wallet_keypool_topup.py Outdated Show resolved Hide resolved
Copy link
Member

@promag promag left a comment

utACK.

Copy link
Member

@MarcoFalke MarcoFalke left a comment

The test is testing nothing

test/functional/wallet_keypool_topup.py Outdated Show resolved Hide resolved
@instagibbs instagibbs force-pushed the keypool_topup_addresstype branch from a80edd7 to 0dcac51 Dec 3, 2018
@instagibbs
Copy link
Member Author

@instagibbs instagibbs commented Dec 3, 2018

Tested that the returned addresses appear to be the expected type.

@meshcollider
Copy link
Member

@meshcollider meshcollider commented Dec 11, 2018

utACK 0dcac51

@MarcoFalke MarcoFalke merged commit 0dcac51 into bitcoin:master Dec 11, 2018
1 check passed
MarcoFalke added a commit that referenced this issue Dec 11, 2018
…ypes

0dcac51 wallet_keypool_topup.py: Test for all keypool address types (Gregory Sanders)

Pull request description:

  To protect against regressions if key scanning is changed.

Tree-SHA512: d1c4bb033bafd97203a3f68fb262a501442be947907d67902f0391fbdec39c095196403c7675e602806cc68d7e2d1f552ab339a58346162379978d06dad1c4bb
Munkybooty added a commit to Munkybooty/dash that referenced this issue Aug 5, 2021
…dress types

0dcac51 wallet_keypool_topup.py: Test for all keypool address types (Gregory Sanders)

Pull request description:

  To protect against regressions if key scanning is changed.

Tree-SHA512: d1c4bb033bafd97203a3f68fb262a501442be947907d67902f0391fbdec39c095196403c7675e602806cc68d7e2d1f552ab339a58346162379978d06dad1c4bb
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants