Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Modify rpc_bind to conform to #14532 behaviour. #14861

Merged
merged 1 commit into from Dec 4, 2018

Conversation

Projects
None yet
3 participants
@dongcarl
Copy link
Contributor

commented Dec 3, 2018

Fixes: #14792

@dongcarl dongcarl changed the title tests: Modify rpc_bind to conform to #14532 behaviour. [WIP] tests: Modify rpc_bind to conform to #14532 behaviour. Dec 3, 2018

@MarcoFalke MarcoFalke added the Tests label Dec 3, 2018

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Dec 3, 2018

Concept ACK

tests: Modify rpc_bind to conform to #14532 behaviour.
- Even when rpcallowip is specified, only bind localhost
- Explicitly bind in run_allowip_test

@dongcarl dongcarl force-pushed the dongcarl:2018-12-fix-rpc-bind-tests branch to f3cf95f Dec 3, 2018

@dongcarl dongcarl changed the title [WIP] tests: Modify rpc_bind to conform to #14532 behaviour. tests: Modify rpc_bind to conform to #14532 behaviour. Dec 3, 2018

@dongcarl

This comment has been minimized.

Copy link
Contributor Author

commented Dec 3, 2018

All tests should pass now. Ready for review.

@laanwj

This comment has been minimized.

Copy link
Member

commented Dec 4, 2018

tested ACK f3cf95f

@laanwj laanwj merged commit f3cf95f into bitcoin:master Dec 4, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Dec 4, 2018

Merge #14861: tests: Modify rpc_bind to conform to #14532 behaviour.
f3cf95f tests: Modify rpc_bind to conform to #14532 behaviour. (Carl Dong)

Pull request description:

  Fixes: #14792

Tree-SHA512: 5ee63a06c92dae5406515e9e483188309b82e07b760f363d8c8ec46a42fe5f75f88724759b0ac8ef596ee28a135626e0582f575855c5dfec2fbfff2249a109f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.