Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Modify rpc_bind to conform to #14532 behaviour. #14861

Merged
merged 1 commit into from Dec 4, 2018

Conversation

@dongcarl
Copy link
Contributor

@dongcarl dongcarl commented Dec 3, 2018

Fixes: #14792

@dongcarl dongcarl changed the title tests: Modify rpc_bind to conform to #14532 behaviour. [WIP] tests: Modify rpc_bind to conform to #14532 behaviour. Dec 3, 2018
@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Dec 3, 2018

Concept ACK

- Even when rpcallowip is specified, only bind localhost
- Explicitly bind in run_allowip_test
@dongcarl dongcarl force-pushed the 2018-12-fix-rpc-bind-tests branch from eddd50d to f3cf95f Dec 3, 2018
@dongcarl dongcarl changed the title [WIP] tests: Modify rpc_bind to conform to #14532 behaviour. tests: Modify rpc_bind to conform to #14532 behaviour. Dec 3, 2018
@dongcarl
Copy link
Contributor Author

@dongcarl dongcarl commented Dec 3, 2018

All tests should pass now. Ready for review.

@laanwj
Copy link
Member

@laanwj laanwj commented Dec 4, 2018

tested ACK f3cf95f

@laanwj laanwj merged commit f3cf95f into bitcoin:master Dec 4, 2018
2 checks passed
laanwj added a commit that referenced this issue Dec 4, 2018
f3cf95f tests: Modify rpc_bind to conform to #14532 behaviour. (Carl Dong)

Pull request description:

  Fixes: #14792

Tree-SHA512: 5ee63a06c92dae5406515e9e483188309b82e07b760f363d8c8ec46a42fe5f75f88724759b0ac8ef596ee28a135626e0582f575855c5dfec2fbfff2249a109f7
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue Apr 29, 2020
… interfaces"

Summary:
We don't support binding to untrusted networks, so avoid a default where that is typical (luke-jr)

3615003952ffbc814bdb53d9d0e45790f152bd2f net: Always default rpcbind to localhost, never "all interfaces"
d6a1287481428d982dc03be3a6d9aeef8398f468 CNetAddr: Add IsBindAny method to check for INADDR_ANY
27c44ef9c61f64d941ab82ec232a68141a2fde90 rpcbind: Warn about exposing RPC to untrusted networks

f3cf95ffdfda935f28260eb34bf20c1449a200c5 tests: Modify rpc_bind to conform to #14532 behaviour.

---

This is a backport of Core [[bitcoin/bitcoin#14532 | PR14532]] and Core [[bitcoin/bitcoin#14861 | PR14861]]

Test Plan:
  ninja check
  ./test/functional/test_runner/rpc_bind

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5880
UdjinM6 added a commit to UdjinM6/dash that referenced this issue Jul 9, 2020
… behaviour.

f3cf95f tests: Modify rpc_bind to conform to bitcoin#14532 behaviour. (Carl Dong)

Pull request description:

  Fixes: bitcoin#14792

Tree-SHA512: 5ee63a06c92dae5406515e9e483188309b82e07b760f363d8c8ec46a42fe5f75f88724759b0ac8ef596ee28a135626e0582f575855c5dfec2fbfff2249a109f7
UdjinM6 added a commit to UdjinM6/dash that referenced this issue Jul 9, 2020
… behaviour.

f3cf95f tests: Modify rpc_bind to conform to bitcoin#14532 behaviour. (Carl Dong)

Pull request description:

  Fixes: bitcoin#14792

Tree-SHA512: 5ee63a06c92dae5406515e9e483188309b82e07b760f363d8c8ec46a42fe5f75f88724759b0ac8ef596ee28a135626e0582f575855c5dfec2fbfff2249a109f7
UdjinM6 added a commit to dashpay/dash that referenced this issue Jul 12, 2020
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants