Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
RPCHelpMan: Support required arguments after optional ones #14875
There was a requirement that required arguments could not be positioned after an optional argument, but the deprecation of priority made the second argument to
Also format all named arguments in the same way (without the wrapping
-prioritisetransaction "txid" dummy fee_delta +prioritisetransaction "txid" ( dummy ) fee_delta Accepts the transaction into mined blocks at a higher (or lower) priority Arguments: -1. "txid" (string, required) The transaction id. -2. dummy (numeric, required) API-Compatibility for previous API. Must be zero or null. +1. txid (string, required) The transaction id. +2. dummy (numeric, optional, default=null) API-Compatibility for previous API. Must be zero or null. DEPRECATED. For forward compatibility use named arguments and omit this parameter. 3. fee_delta (numeric, required) The fee value (in satoshis) to add (or subtract, if negative). Note, that this value is not a fee rate. It is a value to modify absolute fee of the TX.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.