Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
qt: Add warning messages to the debug window #14879
promag left a comment
An alternative approach is to extract the existing alert from the
Anyway, my point is to avoid duplicate code.
@promag Thank you for your review.
That was my first thought exactly :)
I've just moved
By design, a
Sjors left a comment
I don't mind the slight duplication of view code.
The Overview tab is the first thing you see when you launch Bitcoin Core, so I don't see the point in showing warning in other places. That's especially true the first time you launch the app, so everyone will have seen that it's not a release build.
The only exception I can think of is when you open a BIP21/70 URI, so maybe some really critical warnings could also be on the send screen, but currently the warnings, e.g. "new version bit" aren't informative enough for that to be useful.