Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --retry 5 to curl opts in install_db4.sh #14883

Merged
merged 1 commit into from Dec 11, 2018

Conversation

@qubenix
Copy link
Contributor

@qubenix qubenix commented Dec 6, 2018

I ran into some network issue that caused the clang patch to not download and the script exited. A retry would have solved it. The fallback choice, wget, has a default 20 retries.

I chose 5 retries because curl backs of after each try, starting at one second and doubling each time. 5 retries means that worst case scenario would be a total of 31 seconds waiting between attempts. IMO that should be enough tries if internet is working, but not too much if internet is not working.

@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Dec 6, 2018

utACK 522b80b

Neat first-time contribution. Welcome as a contributor! :-)

@laanwj
Copy link
Member

@laanwj laanwj commented Dec 11, 2018

utACK 522b80b

@MarcoFalke MarcoFalke merged commit 522b80b into bitcoin:master Dec 11, 2018
2 checks passed
MarcoFalke added a commit that referenced this issue Dec 11, 2018
522b80b add `--retry 5` to curl opts in install_db4.sh (qubenix)

Pull request description:

  I ran into some network issue that caused the clang patch to not download and the script exited. A retry would have solved it. The fallback choice, `wget`, has a default 20 retries.

  I chose 5 retries because `curl` backs of after each try, starting at one second and doubling each time. 5 retries means that worst case scenario would be a total of 31 seconds waiting between attempts. IMO that should be enough tries if internet is working, but not too much if internet is not working.

Tree-SHA512: ff48e1f8a9d39b9c6fabc616223974f46fadc5a1b30793cdaaf5ea4ce79f7c76efd259bfa9e81a5a7a7cff60b7133d89448faa3f86cc2f9b0c5ac9adf8dd2a9b
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants