Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: Assert named arguments are unique in RPCHelpMan #14885

Merged
merged 1 commit into from Dec 10, 2018

Conversation

Projects
None yet
5 participants
@promag
Copy link
Member

commented Dec 6, 2018

Prevents an obvious mistake.

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Dec 6, 2018

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #14875 (RPCHelpMan: Support required arguments after optional ones by MarcoFalke)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Show resolved Hide resolved src/rpc/util.cpp Outdated

@promag promag changed the title rpc: Assert arguments are unique in RPCHelpMan rpc: Assert named arguments are unique in RPCHelpMan Dec 6, 2018

@promag promag force-pushed the promag:2018-12-assert-unique-args branch Dec 6, 2018

@Empact

This comment has been minimized.

Copy link
Member

commented Dec 6, 2018

nit: might be a bit better to have this validation in the constructor, from a separation of concerns perspective.

@promag promag force-pushed the promag:2018-12-assert-unique-args branch to e09a587 Dec 7, 2018

@promag

This comment has been minimized.

Copy link
Member Author

commented Dec 9, 2018

@Empact done.

@Empact

This comment has been minimized.

Copy link
Member

commented Dec 9, 2018

utACK e09a587

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Dec 9, 2018

utACK e09a587

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Dec 10, 2018

Merge bitcoin#14885: rpc: Assert named arguments are unique in RPCHel…
…pMan

e09a587 rpc: Assert named arguments are unique in RPCHelpMan (João Barbosa)

Pull request description:

  Prevents an obvious mistake.

Tree-SHA512: 32c24a1934b17ab6f0d5cd31bdf0388e93ee5156ccc1b4f78eb9fd7f1d4b27a4b978b594ff11812bc9f20987c9fc36bf4497ddaedf18cf6bcbea19c050571334

@MarcoFalke MarcoFalke merged commit e09a587 into bitcoin:master Dec 10, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.