Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Update minimum required Qt #14909

Merged
merged 1 commit into from Dec 12, 2018

Conversation

Projects
None yet
5 participants
@fanquake
Copy link
Member

commented Dec 10, 2018

After #14725 the minimum required version of Qt is 5.2.

@fanquake fanquake added the Docs label Dec 10, 2018

@hebasto
Copy link
Member

left a comment

Concept ACK.

| Boost | [1.64.0](https://www.boost.org/users/download/) | [1.47.0](https://github.com/bitcoin/bitcoin/pull/8920) | No | | |
| Clang | | [3.3+](https://llvm.org/releases/download.html) (C++11 support) | | | |
| D-Bus | [1.10.18](https://cgit.freedesktop.org/dbus/dbus/tree/NEWS?h=dbus-1.10) | | No | Yes | |
| Expat | [2.2.5](https://libexpat.github.io/) | | No | Yes | |
| fontconfig | [2.12.1](https://www.freedesktop.org/software/fontconfig/release/) | | No | Yes | |
| FreeType | [2.7.1](http://download.savannah.gnu.org/releases/freetype) | | No | | |
| FreeType | [2.7.1](https://download.savannah.gnu.org/releases/freetype) | | No | | |
| GCC | | [4.8+](https://gcc.gnu.org/) (C++11 support) | | | |
| HarfBuzz-NG | | | | | |

This comment has been minimized.

Copy link
@hebasto

hebasto Dec 10, 2018

Member
 | HarfBuzz-NG | | | | | [Yes](https://github.com/bitcoin/bitcoin/blob/master/depends/packages/qt.mk#L67) |
| Boost | [1.64.0](https://www.boost.org/users/download/) | [1.47.0](https://github.com/bitcoin/bitcoin/pull/8920) | No | | |
| Clang | | [3.3+](https://llvm.org/releases/download.html) (C++11 support) | | | |
| D-Bus | [1.10.18](https://cgit.freedesktop.org/dbus/dbus/tree/NEWS?h=dbus-1.10) | | No | Yes | |
| Expat | [2.2.5](https://libexpat.github.io/) | | No | Yes | |
| fontconfig | [2.12.1](https://www.freedesktop.org/software/fontconfig/release/) | | No | Yes | |
| FreeType | [2.7.1](http://download.savannah.gnu.org/releases/freetype) | | No | | |
| FreeType | [2.7.1](https://download.savannah.gnu.org/releases/freetype) | | No | | |

This comment has been minimized.

Copy link
@hebasto

hebasto Dec 10, 2018

Member
| FreeType | [2.7.1](https://download.savannah.gnu.org/releases/freetype) |  | No |  | [No](https://github.com/bitcoin/bitcoin/blob/master/depends/packages/qt.mk#L33) |

And a similar change for zlib?

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Dec 10, 2018

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #14849 ([wip] depends: qt 5.9.7 by fanquake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Dec 10, 2018

ACK b7bee6a

@laanwj

This comment has been minimized.

Copy link
Member

commented Dec 12, 2018

ACK b7bee6a

@laanwj laanwj merged commit b7bee6a into bitcoin:master Dec 12, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Dec 12, 2018

Merge #14909: doc: Update minimum required Qt
b7bee6a doc: Update minimum required qt (fanquake)

Pull request description:

  After #14725 the minimum required version of Qt is 5.2.

Tree-SHA512: 130c69ed6810723ac86eb7a341e5a985af73186d47cb2bce3e5f239991157cfd44bb28903f59e33dc2ebe3d628d21b6864ad6c8223218aae287d0cde7506dc7f

@fanquake fanquake deleted the fanquake:doc-qt-minimum-52 branch Dec 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.