Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add nice table to files.md #14914

Merged
merged 1 commit into from Dec 12, 2018
Merged

Docs: Add nice table to files.md #14914

merged 1 commit into from Dec 12, 2018

Conversation

@emilengler
Copy link
Contributor

@emilengler emilengler commented Dec 10, 2018

I have added a nice table to the files.md in the documentation.
This looks way more better and lightweight than before.
Screenshot

@fanquake fanquake added the Docs label Dec 10, 2018
@promag
Copy link
Member

@promag promag commented Dec 11, 2018

What is the goal here? Have a nice table in the console or in a markdown renderer?

@emilengler
Copy link
Contributor Author

@emilengler emilengler commented Dec 11, 2018

It looks nice in a console window but also in a markdown renderer. The current file looks very crowded

@promag
Copy link
Member

@promag promag commented Dec 11, 2018

You can remove the left and right borders.

@emilengler
Copy link
Contributor Author

@emilengler emilengler commented Dec 11, 2018

Done @promag

@promag
Copy link
Member

@promag promag commented Dec 11, 2018

@emilengler please squash.

doc/files.md Outdated
wallets/wallet.dat | personal wallet (BDB) with keys and transactions; since 0.16.0
.cookie | session RPC authentication cookie (written at start when cookie authentication is used, deleted on shutdown): since 0.12.0
onion_private_key | cached Tor hidden service private key for -listenonion: since 0.12.0
guisettings.ini.bak | backup of former GUI settings after -resetguisettings is used
Copy link
Contributor

@practicalswift practicalswift Dec 11, 2018

Keep the formatting unchanged - preserve backticks :-)

Copy link
Contributor Author

@emilengler emilengler Dec 11, 2018

Ok just was confused by the travis errors

@emilengler
Copy link
Contributor Author

@emilengler emilengler commented Dec 11, 2018

@promag Should be fine now :)
GitHub still displays there are 5 commits. If you click on that you will see only one

@jonasschnelli
Copy link
Contributor

@jonasschnelli jonasschnelli commented Dec 11, 2018

I guess you need to fix the trailing whitespaces...
otherwise this looks good.

doc/files.md Outdated Show resolved Hide resolved
doc/files.md Outdated
wallets/wallet.dat | personal wallet (BDB) with keys and transactions; since 0.16.0
.cookie | session RPC authentication cookie (written at start when cookie authentication is used, deleted on shutdown): since 0.12.0
onion_private_key | cached Tor hidden service private key for -listenonion: since 0.12.0
guisettings.ini.bak | backup of former GUI settings after -resetguisettings is used
Copy link
Member

@MarcoFalke MarcoFalke Dec 11, 2018

Should keep the backtick quotes?

Copy link
Contributor Author

@emilengler emilengler Dec 11, 2018

I have re-added them.
Should I squash before (a possible ) merge ?

@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Dec 11, 2018

@emilengler
Copy link
Contributor Author

@emilengler emilengler commented Dec 11, 2018

@MarcoFalke Done with squashing

Copy link
Member

@promag promag left a comment

Almost there.

doc/files.md Outdated
wallets/db.log | wallet database log file; since 0.16.0
wallets/wallet.dat | personal wallet (BDB) with keys and transactions; since 0.16.0
.cookie | session RPC authentication cookie (written at start when cookie authentication is used, deleted on shutdown): since 0.12.0
onion_private_key | cached Tor hidden service private key for ```-listenonion```: since 0.12.0
Copy link
Member

@promag promag Dec 11, 2018

Just one backtick?

doc/files.md Show resolved Hide resolved
doc/files.md Outdated
wallets/wallet.dat | personal wallet (BDB) with keys and transactions; since 0.16.0
.cookie | session RPC authentication cookie (written at start when cookie authentication is used, deleted on shutdown): since 0.12.0
onion_private_key | cached Tor hidden service private key for ```-listenonion```: since 0.12.0
guisettings.ini.bak | backup of former GUI settings after ```-resetguisettings``` is used
Copy link
Member

@promag promag Dec 11, 2018

Just one backtick?

Update files.md

Fix linting issue

Return to unix line endings

Update files.md

Fix trailing whitespaces

Add backtick quotes

Just one backtick
@emilengler
Copy link
Contributor Author

@emilengler emilengler commented Dec 11, 2018

@promag I changed to one backtick and squashed the commit.

@promag
Copy link
Member

@promag promag commented Dec 11, 2018

ACK 9b51b15.

@fanquake
Copy link
Member

@fanquake fanquake commented Dec 12, 2018

utACK 9b51b15

table

@laanwj
Copy link
Member

@laanwj laanwj commented Dec 12, 2018

LGTM, thanks for contributing to the documentation
utACK 9b51b15

@laanwj laanwj merged commit 9b51b15 into bitcoin:master Dec 12, 2018
2 checks passed
laanwj added a commit that referenced this issue Dec 12, 2018
9b51b15 Add nice table to files.md (Emil Engler)

Pull request description:

  I have added a nice table to the files.md in the documentation.
  This looks way more better and lightweight than before.
  [Screenshot](https://imgur.com/a/wJuQgZN)

Tree-SHA512: 0c59171531b99f3bc898108c7c570e9e8309e7011d6f3b3211b0200eb2354fd4c4211bba5950d450522523f346631e23b87201813337ed5849336d359c0e166d
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants