Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: consensus: Check that final transactions are valid #14926

Merged
merged 2 commits into from Dec 13, 2018

Conversation

@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Dec 11, 2018

There is no check that checks that final transactions are valid, i.e. the consensus rules could be changed (accidentally) with none of the tests failing.

@MarcoFalke MarcoFalke force-pushed the Mf1812-testConsensusFinal branch from fa37de9 to aaaa8eb Dec 11, 2018
@DrahtBot
Copy link
Contributor

@DrahtBot DrahtBot commented Dec 11, 2018

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Coverage

Coverage Change (pull 14926) Reference (master)
Lines -0.0086 % 87.2539 %
Functions +0.0454 % 84.3991 %
Branches +0.0035 % 51.3393 %

Updated at: 2018-12-11T23:27:22.466952.

@laanwj
Copy link
Member

@laanwj laanwj commented Dec 13, 2018

utACK aaaa8eb, thanks for adding consensus code test coverage!

@laanwj laanwj merged commit aaaa8eb into bitcoin:master Dec 13, 2018
1 check passed
laanwj added a commit that referenced this issue Dec 13, 2018
aaaa8eb test: consensus: Check that final transactions are valid (MarcoFalke)
fae3617 test: Correctly deserialize without witness (MarcoFalke)

Pull request description:

  There is no check that checks that final transactions are valid, i.e. the consensus rules could be changed (accidentally) with none of the tests failing.

Tree-SHA512: 48f4c24bfcc525ddbc1bfe8c37131953b464823428c1f7a278ba6d98b98827b6b84a8eb2b33396bfb5b8cc4012b7cc1cd771637f405ea20beddae001c22aa290
@MarcoFalke MarcoFalke deleted the Mf1812-testConsensusFinal branch Dec 13, 2018
christiancfifi added a commit to christiancfifi/dash that referenced this issue Aug 24, 2021
… are valid

Does not include commit (fae3617) that makes a change to code introduced here:
	330b0f3 [qa] p2p segwit tests (Merge bitcoin#8149: Segregated witness rebased)
which I don't think is in Dash

aaaa8eb test: consensus: Check that final transactions are valid (MarcoFalke)
fae3617 test: Correctly deserialize without witness (MarcoFalke)

Pull request description:

  There is no check that checks that final transactions are valid, i.e. the consensus rules could be changed (accidentally) with none of the tests failing.

Tree-SHA512: 48f4c24bfcc525ddbc1bfe8c37131953b464823428c1f7a278ba6d98b98827b6b84a8eb2b33396bfb5b8cc4012b7cc1cd771637f405ea20beddae001c22aa290
christiancfifi added a commit to christiancfifi/dash that referenced this issue Aug 24, 2021
… are valid

Does not include commit (fae3617) that makes a change to code introduced here:
	330b0f3 [qa] p2p segwit tests (Merge bitcoin#8149: Segregated witness rebased)
which I don't think is in Dash

aaaa8eb test: consensus: Check that final transactions are valid (MarcoFalke)
fae3617 test: Correctly deserialize without witness (MarcoFalke)

Pull request description:

  There is no check that checks that final transactions are valid, i.e. the consensus rules could be changed (accidentally) with none of the tests failing.

Tree-SHA512: 48f4c24bfcc525ddbc1bfe8c37131953b464823428c1f7a278ba6d98b98827b6b84a8eb2b33396bfb5b8cc4012b7cc1cd771637f405ea20beddae001c22aa290
christiancfifi added a commit to christiancfifi/dash that referenced this issue Aug 25, 2021
… are valid

Does not include commit (fae3617) that makes a change to code introduced here:
	330b0f3 [qa] p2p segwit tests (Merge bitcoin#8149: Segregated witness rebased)
which I don't think is in Dash

aaaa8eb test: consensus: Check that final transactions are valid (MarcoFalke)
fae3617 test: Correctly deserialize without witness (MarcoFalke)

Pull request description:

  There is no check that checks that final transactions are valid, i.e. the consensus rules could be changed (accidentally) with none of the tests failing.

Tree-SHA512: 48f4c24bfcc525ddbc1bfe8c37131953b464823428c1f7a278ba6d98b98827b6b84a8eb2b33396bfb5b8cc4012b7cc1cd771637f405ea20beddae001c22aa290
christiancfifi added a commit to christiancfifi/dash that referenced this issue Aug 26, 2021
… are valid

Does not include commit (fae3617) that makes a change to code introduced here:
	330b0f3 [qa] p2p segwit tests (Merge bitcoin#8149: Segregated witness rebased)
which I don't think is in Dash

aaaa8eb test: consensus: Check that final transactions are valid (MarcoFalke)
fae3617 test: Correctly deserialize without witness (MarcoFalke)

Pull request description:

  There is no check that checks that final transactions are valid, i.e. the consensus rules could be changed (accidentally) with none of the tests failing.

Tree-SHA512: 48f4c24bfcc525ddbc1bfe8c37131953b464823428c1f7a278ba6d98b98827b6b84a8eb2b33396bfb5b8cc4012b7cc1cd771637f405ea20beddae001c22aa290
christiancfifi added a commit to christiancfifi/dash that referenced this issue Aug 28, 2021
… are valid

Does not include commit (fae3617) that makes a change to code introduced here:
	330b0f3 [qa] p2p segwit tests (Merge bitcoin#8149: Segregated witness rebased)
which I don't think is in Dash

aaaa8eb test: consensus: Check that final transactions are valid (MarcoFalke)
fae3617 test: Correctly deserialize without witness (MarcoFalke)

Pull request description:

  There is no check that checks that final transactions are valid, i.e. the consensus rules could be changed (accidentally) with none of the tests failing.

Tree-SHA512: 48f4c24bfcc525ddbc1bfe8c37131953b464823428c1f7a278ba6d98b98827b6b84a8eb2b33396bfb5b8cc4012b7cc1cd771637f405ea20beddae001c22aa290
christiancfifi added a commit to christiancfifi/dash that referenced this issue Aug 29, 2021
… are valid

Does not include commit (fae3617) that makes a change to code introduced here:
	330b0f3 [qa] p2p segwit tests (Merge bitcoin#8149: Segregated witness rebased)
which I don't think is in Dash

aaaa8eb test: consensus: Check that final transactions are valid (MarcoFalke)
fae3617 test: Correctly deserialize without witness (MarcoFalke)

Pull request description:

  There is no check that checks that final transactions are valid, i.e. the consensus rules could be changed (accidentally) with none of the tests failing.

Tree-SHA512: 48f4c24bfcc525ddbc1bfe8c37131953b464823428c1f7a278ba6d98b98827b6b84a8eb2b33396bfb5b8cc4012b7cc1cd771637f405ea20beddae001c22aa290
christiancfifi added a commit to christiancfifi/dash that referenced this issue Aug 29, 2021
… are valid

Does not include commit (fae3617) that makes a change to code introduced here:
	330b0f3 [qa] p2p segwit tests (Merge bitcoin#8149: Segregated witness rebased)
which I don't think is in Dash

aaaa8eb test: consensus: Check that final transactions are valid (MarcoFalke)
fae3617 test: Correctly deserialize without witness (MarcoFalke)

Pull request description:

  There is no check that checks that final transactions are valid, i.e. the consensus rules could be changed (accidentally) with none of the tests failing.

Tree-SHA512: 48f4c24bfcc525ddbc1bfe8c37131953b464823428c1f7a278ba6d98b98827b6b84a8eb2b33396bfb5b8cc4012b7cc1cd771637f405ea20beddae001c22aa290
christiancfifi added a commit to christiancfifi/dash that referenced this issue Aug 29, 2021
…re valid

aaaa8eb test: consensus: Check that final transactions are valid (MarcoFalke)
fae3617 test: Correctly deserialize without witness (MarcoFalke)

Pull request description:

  There is no check that checks that final transactions are valid, i.e. the consensus rules could be changed (accidentally) with none of the tests failing.

Tree-SHA512: 48f4c24bfcc525ddbc1bfe8c37131953b464823428c1f7a278ba6d98b98827b6b84a8eb2b33396bfb5b8cc4012b7cc1cd771637f405ea20beddae001c22aa290
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants