Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: Allow connections from misbehavior banned peers #14929

Merged
merged 1 commit into from Jan 29, 2019
Merged

net: Allow connections from misbehavior banned peers #14929

merged 1 commit into from Jan 29, 2019

Commits on Jan 22, 2019

  1. Allow connections from misbehavior banned peers.

    This allows incoming connections from peers which are only banned
     due to an automatic misbehavior ban if doing so won't fill inbound.
    
    These peers are preferred for eviction when inbound fills, but may
     still be kept if they fall into the protected classes.  This
     eviction preference lasts the entire life of the connection even
     if the ban expires.
    
    If they misbehave again they'll still get disconnected.
    
    The main purpose of banning on misbehavior is to prevent our
     connections from being wasted on unhelpful peers such as ones
     running incompatible consensus rules.  For inbound peers this
     can be better accomplished with eviction preferences.
    
    A secondary purpose was to reduce resource waste from repeated
     abuse but virtually any attacker can get a nearly unlimited
     supply of addresses, so disconnection is about the best we can
     do.
    gmaxwell committed Jan 22, 2019
    Copy the full SHA
    0297be6 View commit details
    Browse the repository at this point in the history