Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Test for expected return values when calling functions returning a success code #14935

Merged
merged 1 commit into from Dec 14, 2018

Conversation

Projects
None yet
5 participants
@practicalswift
Copy link
Member

commented Dec 12, 2018

Test for expected return values when calling functions returning a success code (instead of discarding the return values).

Note to reviewers: The following commands can be used to verify that the only text fragments added in this PR are BOOST_CHECK(, ! and ) :

$ git diff HEAD~1 | grep -E '^[\-][^\-]' | cut -b2- > before.txt
$ git diff HEAD~1 | grep -E '^[\+][^\+]' | cut -b2- > after.txt
$ cat after.txt | sed 's/BOOST_CHECK(//g' | sed 's/));/);/g' | tr -d '!' > after-sed.txt
$ diff -u before.txt after-sed.txt
$ 

@fanquake fanquake added the Tests label Dec 12, 2018

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Dec 12, 2018

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #14908 (test: Removed implicit CTransaction constructor calls from tests and benchmarks. by lucash-dev)
  • #14906 (refactor: Make explicit CMutableTransaction -> CTransaction conversion. by lucash-dev)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@practicalswift

This comment has been minimized.

Copy link
Member Author

commented Dec 13, 2018

Rebased!

@practicalswift practicalswift force-pushed the practicalswift:test-return-values branch to c84c2b8 Dec 13, 2018

@DrahtBot DrahtBot removed the Needs rebase label Dec 13, 2018

@laanwj

This comment has been minimized.

Copy link
Member

commented Dec 13, 2018

Agree that this improves the tests; ignoring return status is careless.

utACK c84c2b8

@MarcoFalke MarcoFalke merged commit c84c2b8 into bitcoin:master Dec 14, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

MarcoFalke added a commit that referenced this pull request Dec 14, 2018

Merge #14935: tests: Test for expected return values when calling fun…
…ctions returning a success code

c84c2b8 tests: Test for expected return values when calling functions returning a success code (practicalswift)

Pull request description:

  Test for expected return values when calling functions returning a success code (instead of discarding the return values).

  **Note to reviewers:** The following commands can be used to verify that the only text fragments added in this PR are `BOOST_CHECK(`, `!` and `)` :

  ```
  $ git diff HEAD~1 | grep -E '^[\-][^\-]' | cut -b2- > before.txt
  $ git diff HEAD~1 | grep -E '^[\+][^\+]' | cut -b2- > after.txt
  $ cat after.txt | sed 's/BOOST_CHECK(//g' | sed 's/));/);/g' | tr -d '!' > after-sed.txt
  $ diff -u before.txt after-sed.txt
  $
  ```

Tree-SHA512: ff0863ef2046a2eda3c44e9c6b9aedfe167881f2fa58db29fef859416831233ef6502a3a11fd2322bc1a924db83df8d4a5c5879298007f2a7b085e2a7286af70

Empact added a commit to Empact/bitcoin that referenced this pull request Dec 15, 2018

practicalswift added a commit to practicalswift/bitcoin that referenced this pull request Dec 15, 2018

laanwj added a commit that referenced this pull request Dec 16, 2018

Merge #14969: tests: Fix cuckoocache_tests TSAN failure introduced in…
… 14935.

d98a29e Fix cuckoocache_tests TSAN failure introduced in #14935. Fixes #14967. (practicalswift)

Pull request description:

  Fix cuckoocache_tests TSAN failure introduced in #14935. Fixes #14967.

Tree-SHA512: aabbfa3ab41d9f498151a9b50a2a875fd51ed609bb54d89292114f59392aae57c85fdd5b7a04b589fbf598aaf736b425a6f62b12c806a1fa23bdd45d2d2accfb

HashUnlimited pushed a commit to HashUnlimited/chaincoin that referenced this pull request Dec 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.