Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
travis: fix travis would always be green even if it fail #14937
The current travis-ci job would fail only if the last command failed. It would be succeed if other commands than the last one fail.
This PR execute the script in another shell instance, so we should export those variables and bash functions. It would return 1 if the script fail no matter if it's the last command.
Sorry for ruin the travis ci system in #14231
I think that's a good point.
Also I think not saving the cache in cache of failure makes sense, can you be certain what the state of things is when there's a failure?