Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: fix travis would always be green even if it fail #14937

Merged
merged 1 commit into from Dec 13, 2018

Conversation

Projects
None yet
4 participants
@ken2812221
Copy link
Member

commented Dec 12, 2018

The current travis-ci job would fail only if the last command failed. It would be succeed if other commands than the last one fail.

This PR execute the script in another shell instance, so we should export those variables and bash functions. It would return 1 if the script fail no matter if it's the last command.

Sorry for ruin the travis ci system in #14231

Test: https://travis-ci.org/ken2812221/bitcoin/jobs/467086010

@fanquake fanquake added the Tests label Dec 12, 2018

@MarcoFalke MarcoFalke added this to the 0.18.0 milestone Dec 12, 2018

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Dec 12, 2018

Fine with me, but maybe it is not worth the code complexity in the travis yaml to support saving the cache in case of a test (or compile) failure?

@laanwj

This comment has been minimized.

Copy link
Member

commented Dec 13, 2018

Fine with me, but maybe it is not worth the code complexity in the travis yaml to support saving the cache in case of a test (or compile) failure?

I think that's a good point.

Also I think not saving the cache in cache of failure makes sense, can you be certain what the state of things is when there's a failure?

@ken2812221

This comment has been minimized.

Copy link
Member Author

commented Dec 13, 2018

Ok. Let's revert #14231

@ken2812221 ken2812221 force-pushed the ken2812221:travis-fix-save-cache-2 branch to fc91c1f Dec 13, 2018

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Dec 13, 2018

Merge bitcoin#14937: travis: fix travis would always be green even if…
… it fail

fc91c1f Revert "travis: Save cache on build error" (Chun Kuan Lee)

Pull request description:

  The current travis-ci job would fail only if the last command failed. It would be succeed if other commands than the last one fail.

  This PR execute the script in another shell instance, so we should export those variables and bash functions. It would return 1 if the script fail no matter if it's the last command.

  Sorry for ruin the travis ci system in bitcoin#14231

  Test: https://travis-ci.org/ken2812221/bitcoin/jobs/467086010

Tree-SHA512: 4d9d144fe4c7038b4eff6bf8496e821af603d81677142c0884ed52aea6ce3a50150669be4fdad72a5d372456a33a2452d75ec35e8a7ec2bc4bdfbeaeb93e9acb

@MarcoFalke MarcoFalke merged commit fc91c1f into bitcoin:master Dec 13, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@ken2812221 ken2812221 deleted the ken2812221:travis-fix-save-cache-2 branch Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.