Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add test for truncated pushdata script #14940

Merged
merged 1 commit into from Dec 13, 2018

Conversation

Projects
None yet
4 participants
@MarcoFalke
Copy link
Member

commented Dec 12, 2018

Previously not covered by any test

@MarcoFalke MarcoFalke added the Tests label Dec 12, 2018

@MarcoFalke MarcoFalke force-pushed the MarcoFalke:Mf1812-testPushData branch to fa694f7 Dec 12, 2018

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Dec 12, 2018

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Coverage

Coverage Change (pull 14940) Reference (master)
Lines +0.0216 % 87.2575 %
Functions +0.0222 % 84.3646 %
Branches -0.0020 % 51.3641 %

Updated at: 2018-12-12T21:22:11.855381.

@practicalswift

This comment has been minimized.

Copy link
Member

commented Dec 13, 2018

utACK fa694f7

@MarcoFalke Would it be possible to add the absolute numbers (lines/functions/branches) to the coverage table @DrahtBot posts?

@laanwj

This comment has been minimized.

Copy link
Member

commented Dec 13, 2018

Thank you for adding consensus code tests!

utACK fa694f7

@laanwj laanwj merged commit fa694f7 into bitcoin:master Dec 13, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Dec 13, 2018

Merge #14940: test: Add test for truncated pushdata script
fa694f7 test: Add tests for truncated scripts (MarcoFalke)

Pull request description:

  Previously not covered by any test

Tree-SHA512: 9f99659bdf3947271074938456a2fe64f5b39fc868e9aa474cec199a536ae5d7428f1cfa7f361936b71b09ee4c426261e6b25668fa77b8416b30dbe4ddb357f0

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1812-testPushData branch Dec 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.