Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
test: Make g_insecure_rand_ctx thread_local #14953
Some tests might spin up several threads and
Fix that by giving each thread their own randomness context (as opposed to e.g. making
Also, add the
The alternative you suggest (only give each thread their own randomness context when they are multithreaded) would involve (re)writing the
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
Dec 13, 2018
Should those tests perhaps fail explicitly, like in
Or should we make it mandatory in
Some earlier related discussion:
We bumped the requirement from
@theuni wrote there:
So perhaps this depends on if we drop e.g. Ubuntu Trusty 14.04 in the next release.
@MarcoFalke That reasoning seems backwards. We identify what C++ version (and features) we can use based on the platforms we want to support. I don't mean to say that this particular change is a problem, but just because we're considering C++14 does not mean we should drop support for every platform that doesn't support every feature from C++11 or C++14.
Does this mean we have now removed support for OSX 10.10 for the unit tests with this change?
It's probably a bit of both. It's easier to support older platforms if it only causes minor inconveniences.
This change indeed breaks macOS 10.10 support for the unit tests. Afaik it takes a patch with an