Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Fix cuckoocache_tests TSAN failure introduced in 14935. #14969

Merged
merged 1 commit into from Dec 16, 2018

Conversation

@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Dec 15, 2018

Fix cuckoocache_tests TSAN failure introduced in #14935. Fixes #14967.

src/test/cuckoocache_tests.cpp Outdated Show resolved Hide resolved
@fanquake fanquake added the Tests label Dec 15, 2018
@ken2812221
Copy link
Contributor

@ken2812221 ken2812221 commented Dec 15, 2018

Could use assert instead

@fanquake fanquake changed the title Fix cuckoocache_tests TSAN failure introduced in #14935. Fixes #14967. tests: Fix cuckoocache_tests TSAN failure introduced in 14935. Dec 15, 2018
@practicalswift
Copy link
Contributor Author

@practicalswift practicalswift commented Dec 15, 2018

@sipa @ken2812221 Updated. Please re-review :-)

@laanwj
Copy link
Member

@laanwj laanwj commented Dec 15, 2018

utACK (but squash please)

@practicalswift
Copy link
Contributor Author

@practicalswift practicalswift commented Dec 15, 2018

@laanwj Squashed! :-)

@Empact
Copy link
Member

@Empact Empact commented Dec 15, 2018

utACK d98a29e

@ken2812221
Copy link
Contributor

@ken2812221 ken2812221 commented Dec 16, 2018

utACK d98a29e

@laanwj laanwj merged commit d98a29e into bitcoin:master Dec 16, 2018
2 checks passed
laanwj added a commit that referenced this issue Dec 16, 2018
… 14935.

d98a29e Fix cuckoocache_tests TSAN failure introduced in #14935. Fixes #14967. (practicalswift)

Pull request description:

  Fix cuckoocache_tests TSAN failure introduced in #14935. Fixes #14967.

Tree-SHA512: aabbfa3ab41d9f498151a9b50a2a875fd51ed609bb54d89292114f59392aae57c85fdd5b7a04b589fbf598aaf736b425a6f62b12c806a1fa23bdd45d2d2accfb
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue Jun 22, 2020
…functions returning a success code

Summary:
c84c2b8c92 tests: Test for expected return values when calling functions returning a success code (practicalswift)

Pull request description:

  Test for expected return values when calling functions returning a success code (instead of discarding the return values).

  **Note to reviewers:** The following commands can be used to verify that the only text fragments added in this PR are `BOOST_CHECK(`, `!` and `)` :

  ```
  $ git diff HEAD~1 | grep -E '^[\-][^\-]' | cut -b2- > before.txt
  $ git diff HEAD~1 | grep -E '^[\+][^\+]' | cut -b2- > after.txt
  $ cat after.txt | sed 's/BOOST_CHECK(//g' | sed 's/));/);/g' | tr -d '!' > after-sed.txt
  $ diff -u before.txt after-sed.txt
  $
  ```
---

Backport of Core [[bitcoin/bitcoin#14935 | PR14935]] and [[bitcoin/bitcoin#14969 | PR14969]]

Test Plan:
  ninja check

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D6663
@practicalswift practicalswift deleted the cuckoocache_tests branch Apr 10, 2021
dzutte-cpp added a commit to dzutte-cpp/dash that referenced this issue Sep 24, 2021
…uced in 14935.

d98a29e Fix cuckoocache_tests TSAN failure introduced in bitcoin#14935. Fixes bitcoin#14967. (practicalswift)

Pull request description:

  Fix cuckoocache_tests TSAN failure introduced in bitcoin#14935. Fixes bitcoin#14967.

Tree-SHA512: aabbfa3ab41d9f498151a9b50a2a875fd51ed609bb54d89292114f59392aae57c85fdd5b7a04b589fbf598aaf736b425a6f62b12c806a1fa23bdd45d2d2accfb
dzutte-cpp added a commit to dzutte-cpp/dash that referenced this issue Sep 24, 2021
…uced in 14935.

d98a29e Fix cuckoocache_tests TSAN failure introduced in bitcoin#14935. Fixes bitcoin#14967. (practicalswift)

Pull request description:

  Fix cuckoocache_tests TSAN failure introduced in bitcoin#14935. Fixes bitcoin#14967.

Tree-SHA512: aabbfa3ab41d9f498151a9b50a2a875fd51ed609bb54d89292114f59392aae57c85fdd5b7a04b589fbf598aaf736b425a6f62b12c806a1fa23bdd45d2d2accfb
dzutte-cpp added a commit to dzutte-cpp/dash that referenced this issue Sep 24, 2021
…uced in 14935.

d98a29e Fix cuckoocache_tests TSAN failure introduced in bitcoin#14935. Fixes bitcoin#14967. (practicalswift)

Pull request description:

  Fix cuckoocache_tests TSAN failure introduced in bitcoin#14935. Fixes bitcoin#14967.

Tree-SHA512: aabbfa3ab41d9f498151a9b50a2a875fd51ed609bb54d89292114f59392aae57c85fdd5b7a04b589fbf598aaf736b425a6f62b12c806a1fa23bdd45d2d2accfb
dzutte-cpp added a commit to dzutte-cpp/dash that referenced this issue Sep 27, 2021
…uced in 14935.

d98a29e Fix cuckoocache_tests TSAN failure introduced in bitcoin#14935. Fixes bitcoin#14967. (practicalswift)

Pull request description:

  Fix cuckoocache_tests TSAN failure introduced in bitcoin#14935. Fixes bitcoin#14967.

Tree-SHA512: aabbfa3ab41d9f498151a9b50a2a875fd51ed609bb54d89292114f59392aae57c85fdd5b7a04b589fbf598aaf736b425a6f62b12c806a1fa23bdd45d2d2accfb
dzutte-cpp added a commit to dzutte-cpp/dash that referenced this issue Sep 30, 2021
…uced in 14935.

d98a29e Fix cuckoocache_tests TSAN failure introduced in bitcoin#14935. Fixes bitcoin#14967. (practicalswift)

Pull request description:

  Fix cuckoocache_tests TSAN failure introduced in bitcoin#14935. Fixes bitcoin#14967.

Tree-SHA512: aabbfa3ab41d9f498151a9b50a2a875fd51ed609bb54d89292114f59392aae57c85fdd5b7a04b589fbf598aaf736b425a6f62b12c806a1fa23bdd45d2d2accfb
kittywhiskers added a commit to kittywhiskers/dash that referenced this issue Oct 12, 2021
…uced in 14935.

d98a29e Fix cuckoocache_tests TSAN failure introduced in bitcoin#14935. Fixes bitcoin#14967. (practicalswift)

Pull request description:

  Fix cuckoocache_tests TSAN failure introduced in bitcoin#14935. Fixes bitcoin#14967.

Tree-SHA512: aabbfa3ab41d9f498151a9b50a2a875fd51ed609bb54d89292114f59392aae57c85fdd5b7a04b589fbf598aaf736b425a6f62b12c806a1fa23bdd45d2d2accfb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants