Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Fix cuckoocache_tests TSAN failure introduced in 14935. #14969

Merged
merged 1 commit into from Dec 16, 2018

Conversation

Projects
None yet
6 participants
@practicalswift
Copy link
Member

commented Dec 15, 2018

Fix cuckoocache_tests TSAN failure introduced in #14935. Fixes #14967.

Show resolved Hide resolved src/test/cuckoocache_tests.cpp Outdated

@fanquake fanquake added the Tests label Dec 15, 2018

@ken2812221

This comment has been minimized.

Copy link
Member

commented Dec 15, 2018

Could use assert instead

@fanquake fanquake changed the title Fix cuckoocache_tests TSAN failure introduced in #14935. Fixes #14967. tests: Fix cuckoocache_tests TSAN failure introduced in 14935. Dec 15, 2018

@practicalswift

This comment has been minimized.

Copy link
Member Author

commented Dec 15, 2018

@sipa @ken2812221 Updated. Please re-review :-)

@laanwj

This comment has been minimized.

Copy link
Member

commented Dec 15, 2018

utACK (but squash please)

@practicalswift practicalswift force-pushed the practicalswift:cuckoocache_tests branch to d98a29e Dec 15, 2018

@practicalswift

This comment has been minimized.

Copy link
Member Author

commented Dec 15, 2018

@laanwj Squashed! :-)

@Empact

This comment has been minimized.

Copy link
Member

commented Dec 15, 2018

utACK d98a29e

@ken2812221

This comment has been minimized.

Copy link
Member

commented Dec 16, 2018

utACK d98a29e

@laanwj laanwj merged commit d98a29e into bitcoin:master Dec 16, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Dec 16, 2018

Merge #14969: tests: Fix cuckoocache_tests TSAN failure introduced in…
… 14935.

d98a29e Fix cuckoocache_tests TSAN failure introduced in #14935. Fixes #14967. (practicalswift)

Pull request description:

  Fix cuckoocache_tests TSAN failure introduced in #14935. Fixes #14967.

Tree-SHA512: aabbfa3ab41d9f498151a9b50a2a875fd51ed609bb54d89292114f59392aae57c85fdd5b7a04b589fbf598aaf736b425a6f62b12c806a1fa23bdd45d2d2accfb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.